Re: [PATCH v2] powerpc/prom_init: add __init markers to all functions

2019-02-20 Thread Daniel Axtens
Hi Masahiro, > It is fragile to rely on the compiler's optimization to avoid the > section mismatch. Some functions may not be necessarily inlined > when the compiler's inlining heuristic changes. > > Add __init markers consistently. > Are you doing this with some sort of static analysis, or

Re: [PATCH v2] powerpc/prom_init: add __init markers to all functions

2019-02-19 Thread Christophe Leroy
Le 20/02/2019 à 06:53, Masahiro Yamada a écrit : It is fragile to rely on the compiler's optimization to avoid the section mismatch. Some functions may not be necessarily inlined when the compiler's inlining heuristic changes. Add __init markers consistently. As for prom_getprop() and

[PATCH v2] powerpc/prom_init: add __init markers to all functions

2019-02-19 Thread Masahiro Yamada
It is fragile to rely on the compiler's optimization to avoid the section mismatch. Some functions may not be necessarily inlined when the compiler's inlining heuristic changes. Add __init markers consistently. As for prom_getprop() and prom_getproplen(), they are marked as 'inline', so inlining