Re: [PATCH v2 2/2] i2c: busses: make use of i2c_8bit_addr_from_msg

2018-05-29 Thread Wolfram Sang
On Wed, May 16, 2018 at 09:16:47AM +0200, Peter Rosin wrote: > Because it looks neater. > > For diolan, this allows factoring out some code that is now common > between if and else. > > For eg20t, pch_i2c_writebytes is always called with a write in > msgs->flags, and pch_i2c_readbytes with a

Re: [PATCH v2 2/2] i2c: busses: make use of i2c_8bit_addr_from_msg

2018-05-16 Thread Uwe Kleine-König
Hello Peter, On Wed, May 16, 2018 at 09:16:47AM +0200, Peter Rosin wrote: > Acked-by: Uwe Kleine-König [emf32 and imx] s/emf/efm/ Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions

[PATCH v2 2/2] i2c: busses: make use of i2c_8bit_addr_from_msg

2018-05-16 Thread Peter Rosin
Because it looks neater. For diolan, this allows factoring out some code that is now common between if and else. For eg20t, pch_i2c_writebytes is always called with a write in msgs->flags, and pch_i2c_readbytes with a read. For imx, i2c_imx_dma_write and i2c_imx_write are always called with a