Re: [PATCH v2 3/4] powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h
Hi Christophe,
Thanks for your patch! Perhaps something to improve:
[auto build test WARNING on powerpc/next]
[also build test WARNING on mkp-scsi/for-next jejb-scsi/for-next linus/master
v5.19-rc5 next-20220707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Christophe-Leroy/video-fbdev-offb-Include-missing-linux-platform_device-h/20220707-222906
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-randconfig-s032-20220707
(https://download.01.org/0day-ci/archive/20220708/202207080257.3ftiq7ck-...@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
#
https://github.com/intel-lab-lkp/linux/commit/0e553b9abdcfd7c1f63b072e9d9280ce759c0c3c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review
Christophe-Leroy/video-fbdev-offb-Include-missing-linux-platform_device-h/20220707-222906
git checkout 0e553b9abdcfd7c1f63b072e9d9280ce759c0c3c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross C=1
CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc
SHELL=/bin/bash arch/powerpc/kernel/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> arch/powerpc/kernel/prom.c:891:5: warning: no previous prototype for
'of_get_ibm_chip_id' [-Wmissing-prototypes]
891 | int of_get_ibm_chip_id(struct device_node *np)
| ^~
vim +/of_get_ibm_chip_id +891 arch/powerpc/kernel/prom.c
b27652dd2174df1 Kevin Hao 2013-12-24 871
9b6b563c0d2d25e Paul Mackerras 2005-10-06 872 /***
9b6b563c0d2d25e Paul Mackerras 2005-10-06 873 *
9b6b563c0d2d25e Paul Mackerras 2005-10-06 874 * New implementation of the OF
"find" APIs, return a refcounted
9b6b563c0d2d25e Paul Mackerras 2005-10-06 875 * object, call
of_node_put() when done. The device tree and list
9b6b563c0d2d25e Paul Mackerras 2005-10-06 876 * are protected by a
rw_lock.
9b6b563c0d2d25e Paul Mackerras 2005-10-06 877 *
9b6b563c0d2d25e Paul Mackerras 2005-10-06 878 * Note that property
management will need some locking as well,
9b6b563c0d2d25e Paul Mackerras 2005-10-06 879 * this isn't dealt
with yet.
9b6b563c0d2d25e Paul Mackerras 2005-10-06 880 *
9b6b563c0d2d25e Paul Mackerras 2005-10-06 881 ***/
9b6b563c0d2d25e Paul Mackerras 2005-10-06 882
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 883 /**
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 884 * of_get_ibm_chip_id - Returns
the IBM "chip-id" of a device
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 885 * @np: device node of
the device
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 886 *
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 887 * This looks for a property
"ibm,chip-id" in the node or any
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 888 * of its parents and
returns its content, or -1 if it cannot
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 889 * be found.
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 890 */
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 @891 int
of_get_ibm_chip_id(struct device_node *np)
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 892 {
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 893 of_node_get(np);
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 894 while (np) {
1856f50c66dff0a Christophe Jaillet 2015-10-16 895 u32
chip_id;
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 896
1856f50c66dff0a Christophe Jaillet 2015-10-16 897 /*
1856f50c66dff0a Christophe Jaillet 2015-10-16 898 *
Skiboot may produce memory nodes that contain more than one
1856f50c66dff0a Christophe Jaillet 2015-10-16 899 * cell
in chip-id, we only read the first one here.
1856f50c66dff0a Christophe Jaillet 2015-10-16 900 */
1856f50c66dff0a Christophe Jaillet 2015-10-16 901 if
(!of_property_read_u32(np, "ibm,chip-id", _id)) {
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 902
of_node_put(np);
1856f50c66dff0a Christophe Jaillet 2015-10-16 903
return chip_id;
b37193b71846858 Benjamin
Re: [PATCH v2 3/4] powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h
Hi Christophe,
I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on mkp-scsi/for-next jejb-scsi/for-next linus/master
v5.19-rc5 next-20220707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Christophe-Leroy/video-fbdev-offb-Include-missing-linux-platform_device-h/20220707-222906
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-mpc8313_rdb_defconfig
(https://download.01.org/0day-ci/archive/20220708/202207080653.rru2i2nn-...@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project
66ae1d60bb278793fd651cece264699d522bab84)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
#
https://github.com/intel-lab-lkp/linux/commit/0e553b9abdcfd7c1f63b072e9d9280ce759c0c3c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review
Christophe-Leroy/video-fbdev-offb-Include-missing-linux-platform_device-h/20220707-222906
git checkout 0e553b9abdcfd7c1f63b072e9d9280ce759c0c3c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
O=build_dir ARCH=powerpc SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
>> arch/powerpc/kernel/prom.c:891:5: error: no previous prototype for function
>> 'of_get_ibm_chip_id' [-Werror,-Wmissing-prototypes]
int of_get_ibm_chip_id(struct device_node *np)
^
arch/powerpc/kernel/prom.c:891:1: note: declare 'static' if the function is
not intended to be used outside of this translation unit
int of_get_ibm_chip_id(struct device_node *np)
^
static
1 error generated.
vim +/of_get_ibm_chip_id +891 arch/powerpc/kernel/prom.c
b27652dd2174df1 Kevin Hao 2013-12-24 871
9b6b563c0d2d25e Paul Mackerras 2005-10-06 872 /***
9b6b563c0d2d25e Paul Mackerras 2005-10-06 873 *
9b6b563c0d2d25e Paul Mackerras 2005-10-06 874 * New implementation
of the OF "find" APIs, return a refcounted
9b6b563c0d2d25e Paul Mackerras 2005-10-06 875 * object, call
of_node_put() when done. The device tree and list
9b6b563c0d2d25e Paul Mackerras 2005-10-06 876 * are protected by a
rw_lock.
9b6b563c0d2d25e Paul Mackerras 2005-10-06 877 *
9b6b563c0d2d25e Paul Mackerras 2005-10-06 878 * Note that property
management will need some locking as well,
9b6b563c0d2d25e Paul Mackerras 2005-10-06 879 * this isn't dealt
with yet.
9b6b563c0d2d25e Paul Mackerras 2005-10-06 880 *
9b6b563c0d2d25e Paul Mackerras 2005-10-06 881 ***/
9b6b563c0d2d25e Paul Mackerras 2005-10-06 882
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 883 /**
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 884 * of_get_ibm_chip_id -
Returns the IBM "chip-id" of a device
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 885 * @np: device node of
the device
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 886 *
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 887 * This looks for a
property "ibm,chip-id" in the node or any
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 888 * of its parents and
returns its content, or -1 if it cannot
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 889 * be found.
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 890 */
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 @891 int
of_get_ibm_chip_id(struct device_node *np)
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 892 {
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 893 of_node_get(np);
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 894 while (np) {
1856f50c66dff0a Christophe Jaillet 2015-10-16 895 u32
chip_id;
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 896
1856f50c66dff0a Christophe Jaillet 2015-10-16 897 /*
1856f50c66dff0a Christophe Jaillet 2015-10-16 898 *
Skiboot may produce memory nodes that contain more than one
1856f50c66dff0a Christophe Jaillet 2015-10-16 899 * cell
in chip-id, we only read the first one here.
1856f50c66dff0a Christophe Jaillet 2015-10-16 900 */
1856f50c66dff0a Christophe Jaillet 2015-10-16 901 if
(!of_property_read_u32(np,
Re: [PATCH v2 3/4] powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h
Hi Christophe,
I love your patch! Perhaps something to improve:
[auto build test WARNING on powerpc/next]
[also build test WARNING on mkp-scsi/for-next jejb-scsi/for-next linus/master
v5.19-rc5 next-20220707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Christophe-Leroy/video-fbdev-offb-Include-missing-linux-platform_device-h/20220707-222906
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-microwatt_defconfig
(https://download.01.org/0day-ci/archive/20220708/202207080622.vqn3z1bl-...@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project
66ae1d60bb278793fd651cece264699d522bab84)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
#
https://github.com/intel-lab-lkp/linux/commit/0e553b9abdcfd7c1f63b072e9d9280ce759c0c3c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review
Christophe-Leroy/video-fbdev-offb-Include-missing-linux-platform_device-h/20220707-222906
git checkout 0e553b9abdcfd7c1f63b072e9d9280ce759c0c3c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/kernel/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> arch/powerpc/kernel/prom.c:891:5: warning: no previous prototype for
>> function 'of_get_ibm_chip_id' [-Wmissing-prototypes]
int of_get_ibm_chip_id(struct device_node *np)
^
arch/powerpc/kernel/prom.c:891:1: note: declare 'static' if the function is
not intended to be used outside of this translation unit
int of_get_ibm_chip_id(struct device_node *np)
^
static
1 warning generated.
vim +/of_get_ibm_chip_id +891 arch/powerpc/kernel/prom.c
b27652dd2174df1 Kevin Hao 2013-12-24 871
9b6b563c0d2d25e Paul Mackerras 2005-10-06 872 /***
9b6b563c0d2d25e Paul Mackerras 2005-10-06 873 *
9b6b563c0d2d25e Paul Mackerras 2005-10-06 874 * New implementation
of the OF "find" APIs, return a refcounted
9b6b563c0d2d25e Paul Mackerras 2005-10-06 875 * object, call
of_node_put() when done. The device tree and list
9b6b563c0d2d25e Paul Mackerras 2005-10-06 876 * are protected by a
rw_lock.
9b6b563c0d2d25e Paul Mackerras 2005-10-06 877 *
9b6b563c0d2d25e Paul Mackerras 2005-10-06 878 * Note that property
management will need some locking as well,
9b6b563c0d2d25e Paul Mackerras 2005-10-06 879 * this isn't dealt
with yet.
9b6b563c0d2d25e Paul Mackerras 2005-10-06 880 *
9b6b563c0d2d25e Paul Mackerras 2005-10-06 881 ***/
9b6b563c0d2d25e Paul Mackerras 2005-10-06 882
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 883 /**
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 884 * of_get_ibm_chip_id -
Returns the IBM "chip-id" of a device
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 885 * @np: device node of
the device
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 886 *
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 887 * This looks for a
property "ibm,chip-id" in the node or any
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 888 * of its parents and
returns its content, or -1 if it cannot
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 889 * be found.
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 890 */
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 @891 int
of_get_ibm_chip_id(struct device_node *np)
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 892 {
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 893 of_node_get(np);
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 894 while (np) {
1856f50c66dff0a Christophe Jaillet 2015-10-16 895 u32
chip_id;
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 896
1856f50c66dff0a Christophe Jaillet 2015-10-16 897 /*
1856f50c66dff0a Christophe Jaillet 2015-10-16 898 *
Skiboot may produce memory nodes that contain more than one
1856f50c66dff0a Christophe Jaillet 2015-10-16 899 * cell
in chip-id, we only read the first one here.
1856f50c66dff0a Christophe Jaillet 2015-10-16 900 */
1856f50c66dff0a Christophe Jaillet 2015-10-16 901 if
Re: [PATCH v2 3/4] powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h
Hi Christophe,
I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on mkp-scsi/for-next jejb-scsi/for-next linus/master
v5.19-rc5 next-20220707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Christophe-Leroy/video-fbdev-offb-Include-missing-linux-platform_device-h/20220707-222906
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allnoconfig
(https://download.01.org/0day-ci/archive/20220708/202207080212.nbriiauw-...@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/intel-lab-lkp/linux/commit/0e553b9abdcfd7c1f63b072e9d9280ce759c0c3c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review
Christophe-Leroy/video-fbdev-offb-Include-missing-linux-platform_device-h/20220707-222906
git checkout 0e553b9abdcfd7c1f63b072e9d9280ce759c0c3c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1
O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/kernel/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
>> arch/powerpc/kernel/prom.c:891:5: error: no previous prototype for
>> 'of_get_ibm_chip_id' [-Werror=missing-prototypes]
891 | int of_get_ibm_chip_id(struct device_node *np)
| ^~
cc1: all warnings being treated as errors
vim +/of_get_ibm_chip_id +891 arch/powerpc/kernel/prom.c
b27652dd2174df1 Kevin Hao 2013-12-24 871
9b6b563c0d2d25e Paul Mackerras 2005-10-06 872 /***
9b6b563c0d2d25e Paul Mackerras 2005-10-06 873 *
9b6b563c0d2d25e Paul Mackerras 2005-10-06 874 * New implementation
of the OF "find" APIs, return a refcounted
9b6b563c0d2d25e Paul Mackerras 2005-10-06 875 * object, call
of_node_put() when done. The device tree and list
9b6b563c0d2d25e Paul Mackerras 2005-10-06 876 * are protected by a
rw_lock.
9b6b563c0d2d25e Paul Mackerras 2005-10-06 877 *
9b6b563c0d2d25e Paul Mackerras 2005-10-06 878 * Note that property
management will need some locking as well,
9b6b563c0d2d25e Paul Mackerras 2005-10-06 879 * this isn't dealt
with yet.
9b6b563c0d2d25e Paul Mackerras 2005-10-06 880 *
9b6b563c0d2d25e Paul Mackerras 2005-10-06 881 ***/
9b6b563c0d2d25e Paul Mackerras 2005-10-06 882
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 883 /**
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 884 * of_get_ibm_chip_id -
Returns the IBM "chip-id" of a device
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 885 * @np: device node of
the device
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 886 *
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 887 * This looks for a
property "ibm,chip-id" in the node or any
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 888 * of its parents and
returns its content, or -1 if it cannot
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 889 * be found.
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 890 */
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 @891 int
of_get_ibm_chip_id(struct device_node *np)
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 892 {
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 893 of_node_get(np);
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 894 while (np) {
1856f50c66dff0a Christophe Jaillet 2015-10-16 895 u32
chip_id;
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 896
1856f50c66dff0a Christophe Jaillet 2015-10-16 897 /*
1856f50c66dff0a Christophe Jaillet 2015-10-16 898 *
Skiboot may produce memory nodes that contain more than one
1856f50c66dff0a Christophe Jaillet 2015-10-16 899 * cell
in chip-id, we only read the first one here.
1856f50c66dff0a Christophe Jaillet 2015-10-16 900 */
1856f50c66dff0a Christophe Jaillet 2015-10-16 901 if
(!of_property_read_u32(np, "ibm,chip-id", _id)) {
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 902
of_node_put(np);
1856f50c66dff0a Christophe Jaillet 2015-10-16 903
return chip_id;
b37193b71846858 Benjamin Herrenschmidt 2013-07-15 904 }
16c1d606263ea37 Michael Ellerman
[PATCH v2 3/4] powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h
asm/pci.h and asm/mpc52xx.h don't need asm/prom.h
Declare struct device_node locally to avoid including of.h
Signed-off-by: Christophe Leroy
---
arch/powerpc/include/asm/mpc52xx.h | 3 ++-
arch/powerpc/include/asm/pci.h | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/include/asm/mpc52xx.h
b/arch/powerpc/include/asm/mpc52xx.h
index ddd80aae1e32..5ea16a71c2f0 100644
--- a/arch/powerpc/include/asm/mpc52xx.h
+++ b/arch/powerpc/include/asm/mpc52xx.h
@@ -15,7 +15,6 @@
#ifndef __ASSEMBLY__
#include
-#include
#include
#endif /* __ASSEMBLY__ */
@@ -268,6 +267,8 @@ struct mpc52xx_intr {
#ifndef __ASSEMBLY__
+struct device_node;
+
/* mpc52xx_common.c */
extern void mpc5200_setup_xlb_arbiter(void);
extern void mpc52xx_declare_of_platform_devices(void);
diff --git a/arch/powerpc/include/asm/pci.h b/arch/powerpc/include/asm/pci.h
index 915d6ee4b40a..0f182074cdb7 100644
--- a/arch/powerpc/include/asm/pci.h
+++ b/arch/powerpc/include/asm/pci.h
@@ -14,7 +14,6 @@
#include
#include
-#include
#include
/* Return values for pci_controller_ops.probe_mode function */
--
2.36.1
