Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc

2016-10-25 Thread Marc Zyngier
On 25/10/16 15:44, Sören Brinkmann wrote: > On Tue, 2016-10-25 at 12:49:33 +0200, Thomas Gleixner wrote: >> On Tue, 25 Oct 2016, Zubair Lutfullah Kakakhel wrote: >>> On 10/21/2016 10:48 AM, Marc Zyngier wrote: Shouldn't you return an error if irq is zero? >>> >>> I'll add the following fo

Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc

2016-10-25 Thread Sören Brinkmann
On Tue, 2016-10-25 at 12:49:33 +0200, Thomas Gleixner wrote: > On Tue, 25 Oct 2016, Zubair Lutfullah Kakakhel wrote: > > On 10/21/2016 10:48 AM, Marc Zyngier wrote: > > > Shouldn't you return an error if irq is zero? > > > > > > > I'll add the following for the error case > > > > pr_err("%s:

Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc

2016-10-25 Thread Thomas Gleixner
On Tue, 25 Oct 2016, Zubair Lutfullah Kakakhel wrote: > On 10/21/2016 10:48 AM, Marc Zyngier wrote: > > Shouldn't you return an error if irq is zero? > > > > I'll add the following for the error case > > pr_err("%s: Parent exists but interrupts property not defined\n" , > __func__); Pleas

Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc

2016-10-25 Thread Zubair Lutfullah Kakakhel
Hi, Thanks for the review. Some comments in-line. On 10/21/2016 10:48 AM, Marc Zyngier wrote: On 17/10/16 17:52, Zubair Lutfullah Kakakhel wrote: The MIPS based xilfpga platform has the following IRQ structure Peripherals --> xilinx_intcontroller -> mips_cpu_int controller Add support for th

Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc

2016-10-21 Thread Marc Zyngier
On 17/10/16 17:52, Zubair Lutfullah Kakakhel wrote: > The MIPS based xilfpga platform has the following IRQ structure > > Peripherals --> xilinx_intcontroller -> mips_cpu_int controller > > Add support for the driver to chain the irq handler > > Signed-off-by: Zubair Lutfullah Kakakhel > > ---

[Patch v5 04/12] irqchip: xilinx: Add support for parent intc

2016-10-17 Thread Zubair Lutfullah Kakakhel
The MIPS based xilfpga platform has the following IRQ structure Peripherals --> xilinx_intcontroller -> mips_cpu_int controller Add support for the driver to chain the irq handler Signed-off-by: Zubair Lutfullah Kakakhel --- V4 -> V5 Rebased to v4.9-rc1 Missing curly braces V3 -> V4 Clean up