Re: [PATCH] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable
On Tue, Jun 23, 2020 at 12:08 AM Markus Elfring wrote: > > > Fix unchecked return value for clk_prepare_enable. > > > > And because clk_prepare_enable and clk_disable_unprepare should > > check input clock parameter is NULL or not, then we don't need > > to check it before calling the function. > > I propose to split the adjustment of two function implementations > into separate update steps for a small patch series. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n138 > > I suggest to improve the change descriptions accordingly. ok, will update the patches in v2. best regards wang shengjiu
Re: [PATCH] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable
> Fix unchecked return value for clk_prepare_enable. > > And because clk_prepare_enable and clk_disable_unprepare should > check input clock parameter is NULL or not, then we don't need > to check it before calling the function. I propose to split the adjustment of two function implementations into separate update steps for a small patch series. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n138 I suggest to improve the change descriptions accordingly. Regards, Markus