Re: [PATCH] KVM: PPC: Book3S: Move prototypes for KVM functions into kvm_ppc.h

[Daniel Axtens]

>> This moves the prototypes for functions that are only called from
>> assembler code out of asm/asm-prototypes.h into asm/kvm_ppc.h.
>> The prototypes were added in commit ebe4535fbe7a ("KVM: PPC:
>> Book3S HV: sparse: prototypes for functions called from assembler",
>> 2016-10-10), but given that the functions are KVM functions,
>> having them in a KVM header will be better for long-term
>> maintenance.
>>
>> Signed-off-by: Paul Mackerras 
>> ---
>> [For information; I intend to merge this through the KVM tree.]
>>
>>  arch/powerpc/include/asm/asm-prototypes.h | 44 
>> ---
>>  arch/powerpc/include/asm/kvm_ppc.h| 42 +
>>  arch/powerpc/kvm/book3s_64_vio_hv.c   |  1 -
>>  arch/powerpc/kvm/book3s_hv_builtin.c  |  1 -
>>  arch/powerpc/kvm/book3s_hv_ras.c  |  2 +-
>>  arch/powerpc/kvm/book3s_hv_rm_mmu.c   |  1 -
>>  arch/powerpc/kvm/book3s_hv_rm_xics.c  |  1 -
>>  7 files changed, 43 insertions(+), 49 deletions(-)
>
> LGTM.
>
> None of these are EXPORT_SYMBOL'ed, so moving them out of
> asm-prototypes.h is safe from that POV.
>
> cheers

Looks good to me too.

Regards,
Daniel

Re: [PATCH] KVM: PPC: Book3S: Move prototypes for KVM functions into kvm_ppc.h

[Michael Ellerman]

Paul Mackerras  writes:

> This moves the prototypes for functions that are only called from
> assembler code out of asm/asm-prototypes.h into asm/kvm_ppc.h.
> The prototypes were added in commit ebe4535fbe7a ("KVM: PPC:
> Book3S HV: sparse: prototypes for functions called from assembler",
> 2016-10-10), but given that the functions are KVM functions,
> having them in a KVM header will be better for long-term
> maintenance.
>
> Signed-off-by: Paul Mackerras 
> ---
> [For information; I intend to merge this through the KVM tree.]
>
>  arch/powerpc/include/asm/asm-prototypes.h | 44 
> ---
>  arch/powerpc/include/asm/kvm_ppc.h| 42 +
>  arch/powerpc/kvm/book3s_64_vio_hv.c   |  1 -
>  arch/powerpc/kvm/book3s_hv_builtin.c  |  1 -
>  arch/powerpc/kvm/book3s_hv_ras.c  |  2 +-
>  arch/powerpc/kvm/book3s_hv_rm_mmu.c   |  1 -
>  arch/powerpc/kvm/book3s_hv_rm_xics.c  |  1 -
>  7 files changed, 43 insertions(+), 49 deletions(-)

LGTM.

None of these are EXPORT_SYMBOL'ed, so moving them out of
asm-prototypes.h is safe from that POV.

cheers