Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()
On Sun, Jul 27, 2008 at 12:56:04PM -0700, David Miller wrote: Yes, please. IMHO, this driver was really rushed in and that was a huge mistake. If it had gone through linux-next we could have tidied all of this stuff up in a less rushed manner. Or just reviewed in at least some way.. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()
On Mon, 28 Jul 2008 02:37:32 +1000 Stephen Rothwell [EMAIL PROTECTED] wrote: On powerpc (allyesconfig build) we get this error: drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of function 'virt_to_bus' When did mISDN make it into the kernel? And which kernel tree is it in? I don't see it in the Linux next tree I am very interested since we are trying to get mISDN working on the Warp. There was no notice that they got 2.6.26 compiling. Cheers, Sean ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()
On Mon, 28 Jul 2008 02:37:32 +1000 Stephen Rothwell [EMAIL PROTECTED] wrote: On powerpc (allyesconfig build) we get this error: drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of function 'virt_to_bus' Signed-off-by: Stephen Rothwell [EMAIL PROTECTED] Can we please not merge new virt_to_bus users and instead fix the actual code to use the right functions? ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()
From: Alan Cox [EMAIL PROTECTED] Date: Sun, 27 Jul 2008 18:27:09 +0100 On Mon, 28 Jul 2008 02:37:32 +1000 Stephen Rothwell [EMAIL PROTECTED] wrote: On powerpc (allyesconfig build) we get this error: drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of function 'virt_to_bus' Signed-off-by: Stephen Rothwell [EMAIL PROTECTED] Can we please not merge new virt_to_bus users and instead fix the actual code to use the right functions? Yes, please. IMHO, this driver was really rushed in and that was a huge mistake. If it had gone through linux-next we could have tidied all of this stuff up in a less rushed manner. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()
IMHO, this driver was really rushed in and that was a huge mistake. If it had gone through linux-next we could have tidied all of this stuff up in a less rushed manner. ?? This thread *is* about a build failure in linux-next. - R. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()
On Sun, Jul 27, 2008 at 01:33:49PM -0700, Roland Dreier wrote: IMHO, this driver was really rushed in and that was a huge mistake. If it had gone through linux-next we could have tidied all of this stuff up in a less rushed manner. ?? This thread *is* about a build failure in linux-next. mISDN are in -linus which is part of -next and Stephens point is that if we have had mISDN in -next then this would have been fixed before hitting -linus. Maybe Karsten should use davem as gateway as he has anyway been so for other isdn patches lately? Sam ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()
From: Roland Dreier [EMAIL PROTECTED] Date: Sun, 27 Jul 2008 13:33:49 -0700 IMHO, this driver was really rushed in and that was a huge mistake. If it had gone through linux-next we could have tidied all of this stuff up in a less rushed manner. ?? This thread *is* about a build failure in linux-next. The driver went directly into Linus's tree. Stephen hit the build problem once he synced linux-next up with Linus's current tree. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()
Hi Roland, On Sun, 27 Jul 2008 13:33:49 -0700 Roland Dreier [EMAIL PROTECTED] wrote: IMHO, this driver was really rushed in and that was a huge mistake. If it had gone through linux-next we could have tidied all of this stuff up in a less rushed manner. ?? This thread *is* about a build failure in linux-next. I noticed this in Linus' tree ... I did not mention linux-next. -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/ pgpEsY0DSMz7F.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()
Hi Sam, On Sun, 27 Jul 2008 22:43:55 +0200 Sam Ravnborg [EMAIL PROTECTED] wrote: On Sun, Jul 27, 2008 at 01:33:49PM -0700, Roland Dreier wrote: IMHO, this driver was really rushed in and that was a huge mistake. If it had gone through linux-next we could have tidied all of this stuff up in a less rushed manner. ?? This thread *is* about a build failure in linux-next. mISDN are in -linus which is part of -next and Stephens point is that if we have had mISDN in -next then this would have been fixed before hitting -linus. Dave made that point, not me. -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/ pgpqniPdks7Uk.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()
Hi Dave, On Sun, 27 Jul 2008 16:14:32 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: The driver went directly into Linus's tree. Stephen hit the build problem once he synced linux-next up with Linus's current tree. It didn't even get as far as linux-next, I was just browsing the bloodbath that is/was Linus' tree (http://kisskb.ellerman.id.au/kisskb/branch/3/) :-(. -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/ pgpqLy3X1qfwa.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()
Hi Sean, On Sun, 27 Jul 2008 13:39:18 -0400 Sean MacLennan [EMAIL PROTECTED] wrote: On Mon, 28 Jul 2008 02:37:32 +1000 Stephen Rothwell [EMAIL PROTECTED] wrote: On powerpc (allyesconfig build) we get this error: drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of function 'virt_to_bus' When did mISDN make it into the kernel? And which kernel tree is it in? I don't see it in the Linux next tree Its not in linux-next (will be today). It went straight into Linus' tree late last week. I am very interested since we are trying to get mISDN working on the Warp. There was no notice that they got 2.6.26 compiling. It won't even build on powerpc64, powercp32 should at least build. -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/ pgphj9SXyWJry.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
