Re: [PATCH] mm: add account_locked_vm utility function

2019-05-24 Thread Alexey Kardashevskiy
On 21/05/2019 01:30, Daniel Jordan wrote: > On Mon, May 20, 2019 at 04:19:34PM +1000, Alexey Kardashevskiy wrote: >> On 04/05/2019 06:16, Daniel Jordan wrote: >>> locked_vm accounting is done roughly the same way in five places, so >>> unify them in a helper. Standardize the debug prints,

Re: [PATCH] mm: add account_locked_vm utility function

2019-05-20 Thread Daniel Jordan
On Mon, May 20, 2019 at 04:19:34PM +1000, Alexey Kardashevskiy wrote: > On 04/05/2019 06:16, Daniel Jordan wrote: > > locked_vm accounting is done roughly the same way in five places, so > > unify them in a helper. Standardize the debug prints, which vary > > slightly. > > And I rather liked

Re: [PATCH] mm: add account_locked_vm utility function

2019-05-20 Thread Alexey Kardashevskiy
On 04/05/2019 06:16, Daniel Jordan wrote: > locked_vm accounting is done roughly the same way in five places, so > unify them in a helper. Standardize the debug prints, which vary > slightly. And I rather liked that prints were different and tell precisely which one of three each printk is.

Re: [PATCH] mm: add account_locked_vm utility function

2019-05-06 Thread Daniel Jordan
On Fri, May 03, 2019 at 11:28:22PM +, Jason Gunthorpe wrote: > On Fri, May 03, 2019 at 01:16:30PM -0700, Daniel Jordan wrote: > > Andrew, this one patch replaces these six from [1]: > > > > mm-change-locked_vms-type-from-unsigned-long-to-atomic64_t.patch > >

Re: [PATCH] mm: add account_locked_vm utility function

2019-05-03 Thread Jason Gunthorpe
On Fri, May 03, 2019 at 01:16:30PM -0700, Daniel Jordan wrote: > locked_vm accounting is done roughly the same way in five places, so > unify them in a helper. Standardize the debug prints, which vary > slightly. Error codes stay the same, so user-visible behavior does too. > > Signed-off-by: