Re: [PATCH] powerpc/cell: Only build Axon MSI driver for IBM Cell Blades
On Thu, 2009-03-05 at 01:13 -0600, Olof Johansson wrote: On Thu, Mar 05, 2009 at 03:41:41PM +1100, Michael Ellerman wrote: The hardware is only present on those machines, and the driver depends on infrastructure which is selected by the Kconfig for cell blades. Wouldn't it make more sense to make a separate (AXON_MSI) config option depend on PPC_IBM_CELL_BLADE? Maybe, it would make the makefile cleaner, at the expense of a bit more Kconfig. I'm not sure what people prefer, I guess I'm neutral and you're voting for the latter, so I'll respin it that way :) cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc Description: This is a digitally signed message part ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc/cell: Only build Axon MSI driver for IBM Cell Blades
On Fri, Mar 06, 2009 at 01:07:05AM +1100, Michael Ellerman wrote: On Thu, 2009-03-05 at 01:13 -0600, Olof Johansson wrote: On Thu, Mar 05, 2009 at 03:41:41PM +1100, Michael Ellerman wrote: The hardware is only present on those machines, and the driver depends on infrastructure which is selected by the Kconfig for cell blades. Wouldn't it make more sense to make a separate (AXON_MSI) config option depend on PPC_IBM_CELL_BLADE? Maybe, it would make the makefile cleaner, at the expense of a bit more Kconfig. I'm not sure what people prefer, I guess I'm neutral and you're voting for the latter, so I'll respin it that way :) Yeah, I'm not really that picky either, it just set off a red flag w.r.t. setting a bad precedence on ifdef:ing in the makefile instead of Kconfig engineering. Slippery slope and all that. -Olof ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc/cell: Only build Axon MSI driver for IBM Cell Blades
On Thu, Mar 05, 2009 at 03:41:41PM +1100, Michael Ellerman wrote: The hardware is only present on those machines, and the driver depends on infrastructure which is selected by the Kconfig for cell blades. Wouldn't it make more sense to make a separate (AXON_MSI) config option depend on PPC_IBM_CELL_BLADE? -Olof --- a/arch/powerpc/platforms/cell/Makefile +++ b/arch/powerpc/platforms/cell/Makefile @@ -28,7 +28,9 @@ obj-$(CONFIG_SPU_BASE) += spu_callbacks.o spu_base.o \ $(spu-manage-y) \ spufs/ +ifeq ($(CONFIG_PPC_IBM_CELL_BLADE),y) obj-$(CONFIG_PCI_MSI)+= axon_msi.o +endif # qpace setup obj-$(CONFIG_PPC_CELL_QPACE) += qpace_setup.o ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
