On Tue, 31 May 2022 at 08:53, Madhavan Srinivasan wrote:
>
>
> On 5/26/22 12:07 PM, Joel Stanley wrote:
> > When booting on a machine that uses the compat pmu driver we see this:
> >
> > [0.071192] GENERIC_COMPAT performance monitor hardware support
> > registered
> Sorry that was my mistake.
> I agree having it as ISAv3 is better.
Okay. The downside of this is it's not as clear that you're using a
fallback driver.
I'll send a v2 with ISAv3
>
> Maddy
>
> >
> > Which is a bit shouty. Give it a nicer name.
> >
> > Signed-off-by: Joel Stanley
> > ---
> >
> > Other options:
> >
> > - ISAv3 (because it is relevant for PowerISA 3.0B and beyond, see the
> > comment in init_generic_compat_pmu)
> >
> > - Generic Compat (same, but less shouty)
> >
> > arch/powerpc/perf/generic-compat-pmu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/perf/generic-compat-pmu.c
> > b/arch/powerpc/perf/generic-compat-pmu.c
> > index f3db88aee4dd..5be5a5ebaf42 100644
> > --- a/arch/powerpc/perf/generic-compat-pmu.c
> > +++ b/arch/powerpc/perf/generic-compat-pmu.c
> > @@ -292,7 +292,7 @@ static int generic_compute_mmcr(u64 event[], int n_ev,
> > }
> >
> > static struct power_pmu generic_compat_pmu = {
> > - .name = "GENERIC_COMPAT",
> > + .name = "Architected",
> > .n_counter = MAX_PMU_COUNTERS,
> > .add_fields = ISA207_ADD_FIELDS,
> > .test_adder = ISA207_TEST_ADDER,
