Re: [PATCH] powerpc: Add KVM guest defconfig
Satheesh Rajendran writes: > On Mon, Nov 12, 2018 at 11:24:08PM +1100, Michael Ellerman wrote: >> Satheesh Rajendran writes: >> >> > On Thu, Nov 08, 2018 at 04:23:07PM -0200, Breno Leitao wrote: >> >> hi Satheesh, >> >> >> >> On 11/08/2018 03:08 AM, sathn...@linux.vnet.ibm.com wrote: >> >> > --- /dev/null >> >> > +++ b/arch/powerpc/configs/guest.config >> >> > @@ -0,0 +1,14 @@ >> >> > +CONFIG_VIRTIO_BLK=y >> >> > +CONFIG_VIRTIO_BLK_SCSI=y >> >> > +CONFIG_SCSI_VIRTIO=y >> >> > +CONFIG_VIRTIO_NET=y >> >> > +CONFIG_NET_FAILOVER=y >> >> > +CONFIG_VIRTIO_CONSOLE=y >> >> > +CONFIG_VIRTIO=y >> >> > +CONFIG_VIRTIO_PCI=y >> >> > +CONFIG_KVM_GUEST=y >> >> > +CONFIG_EPAPR_PARAVIRT=y >> >> > +CONFIG_XFS_FS=y >> >> >> >> Why a guest kernel needs to have XFS integrated in the core image? I am >> >> wondering if it is a requirement from another CONFIG_ option. >> > >> > Idea is to have a working config which would boot guest without initramfs, >> > other FS(like EXT4) is already integrated in the core image, >> > thought this would be helpful for distributions, which default XFS as root >> > disk. >> >> Maybe we should switch XFS_FS to Y in ppc64_defconfig ? > > Sure, makes sense, will send it for ppc64_defconfig instead. > Inaddition, Have few more symbols to be enabled for cgroups, > memhotplug,numa balancing. > I guess these symbols can also go to ppc64_defconfig itself?. > > i.e, > > CONFIG_CGROUP_SCHED=y > CONFIG_MEMCG=y > CONFIG_CGROUP_SCHED=y > CONFIG_CGROUP_FREEZER=y > CONFIG_CGROUP_DEVICE=y > CONFIG_CGROUP_CPUACCT=y > CONFIG_CGROUP_PERF=y > CONFIG_MEMORY_HOTPLUG=y > CONFIG_MEMORY_HOTREMOVE=y > CONFIG_NUMA_BALANCING=y Yeah I don't see why not, they're probably more or less required by modern distros. cheers
Re: [PATCH] powerpc: Add KVM guest defconfig
On Mon, Nov 12, 2018 at 11:24:08PM +1100, Michael Ellerman wrote: > Satheesh Rajendran writes: > > > On Thu, Nov 08, 2018 at 04:23:07PM -0200, Breno Leitao wrote: > >> hi Satheesh, > >> > >> On 11/08/2018 03:08 AM, sathn...@linux.vnet.ibm.com wrote: > >> > --- /dev/null > >> > +++ b/arch/powerpc/configs/guest.config > >> > @@ -0,0 +1,14 @@ > >> > +CONFIG_VIRTIO_BLK=y > >> > +CONFIG_VIRTIO_BLK_SCSI=y > >> > +CONFIG_SCSI_VIRTIO=y > >> > +CONFIG_VIRTIO_NET=y > >> > +CONFIG_NET_FAILOVER=y > >> > +CONFIG_VIRTIO_CONSOLE=y > >> > +CONFIG_VIRTIO=y > >> > +CONFIG_VIRTIO_PCI=y > >> > +CONFIG_KVM_GUEST=y > >> > +CONFIG_EPAPR_PARAVIRT=y > >> > +CONFIG_XFS_FS=y > >> > >> Why a guest kernel needs to have XFS integrated in the core image? I am > >> wondering if it is a requirement from another CONFIG_ option. > > > > Idea is to have a working config which would boot guest without initramfs, > > other FS(like EXT4) is already integrated in the core image, > > thought this would be helpful for distributions, which default XFS as root > > disk. > > Maybe we should switch XFS_FS to Y in ppc64_defconfig ? Sure, makes sense, will send it for ppc64_defconfig instead. Inaddition, Have few more symbols to be enabled for cgroups, memhotplug,numa balancing. I guess these symbols can also go to ppc64_defconfig itself?. i.e, CONFIG_CGROUP_SCHED=y CONFIG_MEMCG=y CONFIG_CGROUP_SCHED=y CONFIG_CGROUP_FREEZER=y CONFIG_CGROUP_DEVICE=y CONFIG_CGROUP_CPUACCT=y CONFIG_CGROUP_PERF=y CONFIG_MEMORY_HOTPLUG=y CONFIG_MEMORY_HOTREMOVE=y CONFIG_NUMA_BALANCING=y Thanks! -Satheesh. > > cheers >
Re: [PATCH] powerpc: Add KVM guest defconfig
Satheesh Rajendran writes: > On Thu, Nov 08, 2018 at 04:23:07PM -0200, Breno Leitao wrote: >> hi Satheesh, >> >> On 11/08/2018 03:08 AM, sathn...@linux.vnet.ibm.com wrote: >> > --- /dev/null >> > +++ b/arch/powerpc/configs/guest.config >> > @@ -0,0 +1,14 @@ >> > +CONFIG_VIRTIO_BLK=y >> > +CONFIG_VIRTIO_BLK_SCSI=y >> > +CONFIG_SCSI_VIRTIO=y >> > +CONFIG_VIRTIO_NET=y >> > +CONFIG_NET_FAILOVER=y >> > +CONFIG_VIRTIO_CONSOLE=y >> > +CONFIG_VIRTIO=y >> > +CONFIG_VIRTIO_PCI=y >> > +CONFIG_KVM_GUEST=y >> > +CONFIG_EPAPR_PARAVIRT=y >> > +CONFIG_XFS_FS=y >> >> Why a guest kernel needs to have XFS integrated in the core image? I am >> wondering if it is a requirement from another CONFIG_ option. > > Idea is to have a working config which would boot guest without initramfs, > other FS(like EXT4) is already integrated in the core image, > thought this would be helpful for distributions, which default XFS as root > disk. Maybe we should switch XFS_FS to Y in ppc64_defconfig ? cheers
Re: [PATCH] powerpc: Add KVM guest defconfig
hi Satheesh, On 11/09/2018 07:59 AM, Satheesh Rajendran wrote: > On Thu, Nov 08, 2018 at 04:23:07PM -0200, Breno Leitao wrote: >> hi Satheesh, >> >> On 11/08/2018 03:08 AM, sathn...@linux.vnet.ibm.com wrote: >>> --- /dev/null >>> +++ b/arch/powerpc/configs/guest.config >>> @@ -0,0 +1,14 @@ >>> +CONFIG_VIRTIO_BLK=y >>> +CONFIG_VIRTIO_BLK_SCSI=y >>> +CONFIG_SCSI_VIRTIO=y >>> +CONFIG_VIRTIO_NET=y >>> +CONFIG_NET_FAILOVER=y >>> +CONFIG_VIRTIO_CONSOLE=y >>> +CONFIG_VIRTIO=y >>> +CONFIG_VIRTIO_PCI=y >>> +CONFIG_KVM_GUEST=y >>> +CONFIG_EPAPR_PARAVIRT=y >>> +CONFIG_XFS_FS=y >> >> Why a guest kernel needs to have XFS integrated in the core image? I am >> wondering if it is a requirement from another CONFIG_ option. > > Idea is to have a working config which would boot guest without initramfs, > other FS(like EXT4) is already integrated in the core image, > thought this would be helpful for distributions, which default XFS as root > disk. Nice! That makes sense and it is a good idea. Thanks!
Re: [PATCH] powerpc: Add KVM guest defconfig
On Thu, Nov 08, 2018 at 04:23:07PM -0200, Breno Leitao wrote: > hi Satheesh, > > On 11/08/2018 03:08 AM, sathn...@linux.vnet.ibm.com wrote: > > --- /dev/null > > +++ b/arch/powerpc/configs/guest.config > > @@ -0,0 +1,14 @@ > > +CONFIG_VIRTIO_BLK=y > > +CONFIG_VIRTIO_BLK_SCSI=y > > +CONFIG_SCSI_VIRTIO=y > > +CONFIG_VIRTIO_NET=y > > +CONFIG_NET_FAILOVER=y > > +CONFIG_VIRTIO_CONSOLE=y > > +CONFIG_VIRTIO=y > > +CONFIG_VIRTIO_PCI=y > > +CONFIG_KVM_GUEST=y > > +CONFIG_EPAPR_PARAVIRT=y > > +CONFIG_XFS_FS=y > > Why a guest kernel needs to have XFS integrated in the core image? I am > wondering if it is a requirement from another CONFIG_ option. Idea is to have a working config which would boot guest without initramfs, other FS(like EXT4) is already integrated in the core image, thought this would be helpful for distributions, which default XFS as root disk. Hope this should be fine? > > If it is not a strict requirement from another config, I think we can keep it > as defined at ppc64_defconfig, which defines it as module (CONFIG_XFS_FS=m). > > Thanks for this patch, very useful. Thanks Breno! :-) -Satheesh. > Breno >
Re: [PATCH] powerpc: Add KVM guest defconfig
hi Satheesh, On 11/08/2018 03:08 AM, sathn...@linux.vnet.ibm.com wrote: > --- /dev/null > +++ b/arch/powerpc/configs/guest.config > @@ -0,0 +1,14 @@ > +CONFIG_VIRTIO_BLK=y > +CONFIG_VIRTIO_BLK_SCSI=y > +CONFIG_SCSI_VIRTIO=y > +CONFIG_VIRTIO_NET=y > +CONFIG_NET_FAILOVER=y > +CONFIG_VIRTIO_CONSOLE=y > +CONFIG_VIRTIO=y > +CONFIG_VIRTIO_PCI=y > +CONFIG_KVM_GUEST=y > +CONFIG_EPAPR_PARAVIRT=y > +CONFIG_XFS_FS=y Why a guest kernel needs to have XFS integrated in the core image? I am wondering if it is a requirement from another CONFIG_ option. If it is not a strict requirement from another config, I think we can keep it as defined at ppc64_defconfig, which defines it as module (CONFIG_XFS_FS=m). Thanks for this patch, very useful. Breno
