Re: [PATCH 0/9] Fixes and Enablement of ibm,drc-info property

2019-11-07 Thread Michael Ellerman
Tyrel Datwyler  writes:
> On 11/5/19 9:03 AM, Thomas Falcon wrote:
>> On 11/5/19 9:24 AM, Tyrel Datwyler wrote:
..
>>>
>>> This serious fixs the short comings of the previous submission
>> 
>> Either "seriously fixes the shortcomings", or "fixes the serious 
>> shortcomings?"

> Should be "series" as in this "patch series".

This serious series seriously fixes the series of serious shortcomings?

:P

cheers


Re: [PATCH 0/9] Fixes and Enablement of ibm,drc-info property

2019-11-06 Thread Tyrel Datwyler
On 11/5/19 9:03 AM, Thomas Falcon wrote:
> 
> On 11/5/19 9:24 AM, Tyrel Datwyler wrote:
> 
> Hi, just pointing out a few typos...

Damn, I thought I squashed them all the second time around.

>> There was a previous effort to add support for the PAPR
>> architected ibm,drc-info property. This property provides a more
>> memory compact representation of a paritions Dynamic Reconfig
> s/paritions/partition's
>> Connectors (DRC). These can otherwise be thought of as currently
>> partitioned, or available but yet to be partitioned system resources
>> such as cpus, memory, and physical/logical IOA devices.
>>
>> The initial implementation proved buggy and was fully turned of by
> 
> s/turned of/turned off
> 
>> disabling the bit in the appropriate CAS support vector. We now have
>> PowerVM firmware in the field that supports this new property, and
>> further to suppport partitions with 24TB+ of possible memory this
> s/suppport/support
>> property is required to perform platform migration.
>>
>> This serious fixs the short comings of the previous submission
> 
> Either "seriously fixes the shortcomings", or "fixes the serious 
> shortcomings?"
Should be "series" as in this "patch series".

-Tyrel

> 
> Thanks,
> 
> Tom
> 
>> in the areas of general implementation, cpu hotplug, and IOA hotplug.
>>
>> Tyrel Datwyler (9):
>>    powerpc/pseries: Fix bad drc_index_start value parsing of drc-info
>>  entry
>>    powerpc/pseries: Fix drc-info mappings of logical cpus to drc-index
>>    powerpc/pseries: Add cpu DLPAR support for drc-info property
>>    PCI: rpaphp: Fix up pointer to first drc-info entry
>>    PCI: rpaphp: Don't rely on firmware feature to imply drc-info support
>>    PCI: rpaphp: Add drc-info support for hotplug slot registration
>>    PCI: rpaphp: annotate and correctly byte swap DRC properties
>>    PCI: rpaphp: Correctly match ibm,my-drc-index to drc-name when using
>>  drc-info
>>    powerpc/pseries: Enable support for ibm,drc-info property
>>
>>   arch/powerpc/kernel/prom_init.c |   2 +-
>>   arch/powerpc/platforms/pseries/hotplug-cpu.c    | 101 ---
>>   arch/powerpc/platforms/pseries/of_helpers.c |   8 +-
>>   arch/powerpc/platforms/pseries/pseries_energy.c |  23 ++---
>>   drivers/pci/hotplug/rpaphp_core.c   | 124 
>> +---
>>   5 files changed, 187 insertions(+), 71 deletions(-)
>>



Re: [PATCH 0/9] Fixes and Enablement of ibm,drc-info property

2019-11-05 Thread Thomas Falcon



On 11/5/19 9:24 AM, Tyrel Datwyler wrote:

Hi, just pointing out a few typos...

There was a previous effort to add support for the PAPR
architected ibm,drc-info property. This property provides a more
memory compact representation of a paritions Dynamic Reconfig

s/paritions/partition's

Connectors (DRC). These can otherwise be thought of as currently
partitioned, or available but yet to be partitioned system resources
such as cpus, memory, and physical/logical IOA devices.

The initial implementation proved buggy and was fully turned of by


s/turned of/turned off


disabling the bit in the appropriate CAS support vector. We now have
PowerVM firmware in the field that supports this new property, and
further to suppport partitions with 24TB+ of possible memory this

s/suppport/support

property is required to perform platform migration.

This serious fixs the short comings of the previous submission


Either "seriously fixes the shortcomings", or "fixes the serious 
shortcomings?"


Thanks,

Tom


in the areas of general implementation, cpu hotplug, and IOA hotplug.

Tyrel Datwyler (9):
   powerpc/pseries: Fix bad drc_index_start value parsing of drc-info
 entry
   powerpc/pseries: Fix drc-info mappings of logical cpus to drc-index
   powerpc/pseries: Add cpu DLPAR support for drc-info property
   PCI: rpaphp: Fix up pointer to first drc-info entry
   PCI: rpaphp: Don't rely on firmware feature to imply drc-info support
   PCI: rpaphp: Add drc-info support for hotplug slot registration
   PCI: rpaphp: annotate and correctly byte swap DRC properties
   PCI: rpaphp: Correctly match ibm,my-drc-index to drc-name when using
 drc-info
   powerpc/pseries: Enable support for ibm,drc-info property

  arch/powerpc/kernel/prom_init.c |   2 +-
  arch/powerpc/platforms/pseries/hotplug-cpu.c| 101 ---
  arch/powerpc/platforms/pseries/of_helpers.c |   8 +-
  arch/powerpc/platforms/pseries/pseries_energy.c |  23 ++---
  drivers/pci/hotplug/rpaphp_core.c   | 124 +---
  5 files changed, 187 insertions(+), 71 deletions(-)