Re: [PATCH 1/2] crypto: talitos - don't persistently map req_ctx->hw_context and req_ctx->buf
On Mon, Feb 26, 2018 at 05:40:04PM +0100, Christophe Leroy wrote: > Commit 49f9783b0cea ("crypto: talitos - do hw_context DMA mapping > outside the requests") introduced a persistent dma mapping of > req_ctx->hw_context > Commit 37b5e8897eb5 ("crypto: talitos - chain in buffered data for ahash > on SEC1") introduced a persistent dma mapping of req_ctx->buf > > As there is no destructor for req_ctx (the request context), the > associated dma handlers where set in ctx (the tfm context). This is > wrong as several hash operations can run with the same ctx. > > This patch removes this persistent mapping. > > Reported-by: Horia Geanta > Fixes: 49f9783b0cea ("crypto: talitos - do hw_context DMA mapping outside the > requests") > Fixes: 37b5e8897eb5 ("crypto: talitos - chain in buffered data for ahash on > SEC1") > Signed-off-by: Christophe Leroy Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [PATCH 1/2] crypto: talitos - don't persistently map req_ctx->hw_context and req_ctx->buf
On 2/26/2018 6:40 PM, Christophe Leroy wrote: > Commit 49f9783b0cea ("crypto: talitos - do hw_context DMA mapping > outside the requests") introduced a persistent dma mapping of > req_ctx->hw_context > Commit 37b5e8897eb5 ("crypto: talitos - chain in buffered data for ahash > on SEC1") introduced a persistent dma mapping of req_ctx->buf > > As there is no destructor for req_ctx (the request context), the > associated dma handlers where set in ctx (the tfm context). This is > wrong as several hash operations can run with the same ctx. > > This patch removes this persistent mapping. > > Reported-by: Horia Geanta > Fixes: 49f9783b0cea ("crypto: talitos - do hw_context DMA mapping outside the > requests") > Fixes: 37b5e8897eb5 ("crypto: talitos - chain in buffered data for ahash on > SEC1") > Signed-off-by: Christophe Leroy Tested-by: Horia Geantă Please add this to 4.15.y -stable tree. Thanks, Horia