Re: [PATCH 2/2] powerpc/usb: fix bug of CPU hang when missing USB PHY clock
On Mon, 20 Aug 2012, Kumar Gala wrote: Subject: Re: [PATCH 2/2] powerpc/usb: fix bug of CPU hang when missing USB PHY clock On Aug 10, 2012, at 5:48 AM, Shengzhou Liu wrote: when missing USB PHY clock, kernel booting up will hang during USB initialization. We should check USBGP[PHY_CLK_VALID] bit to avoid CPU hanging in this case. Signed-off-by: Shengzhou Liu shengzhou@freescale.com --- drivers/usb/host/ehci-fsl.c | 63 ++--- - drivers/usb/host/ehci-fsl.h |1 + 2 files changed, 46 insertions(+), 18 deletions(-) I assume this should be considered a bug fix and be looked at for inclusion in v3.6? - k [Shengzhou] Yes. Greg, ping? Greg is away on vacation for the rest of this week. Alan Stern ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 2/2] powerpc/usb: fix bug of CPU hang when missing USB PHY clock
On Aug 12, 2012, at 10:01 PM, Liu Shengzhou-B36685 wrote: -Original Message- From: Kumar Gala [mailto:ga...@kernel.crashing.org] Sent: Friday, August 10, 2012 9:50 PM To: Liu Shengzhou-B36685 Cc: linuxppc-dev@lists.ozlabs.org list; linux-...@vger.kernel.org; gre...@linuxfoundation.org Subject: Re: [PATCH 2/2] powerpc/usb: fix bug of CPU hang when missing USB PHY clock On Aug 10, 2012, at 5:48 AM, Shengzhou Liu wrote: when missing USB PHY clock, kernel booting up will hang during USB initialization. We should check USBGP[PHY_CLK_VALID] bit to avoid CPU hanging in this case. Signed-off-by: Shengzhou Liu shengzhou@freescale.com --- drivers/usb/host/ehci-fsl.c | 63 ++--- - drivers/usb/host/ehci-fsl.h |1 + 2 files changed, 46 insertions(+), 18 deletions(-) I assume this should be considered a bug fix and be looked at for inclusion in v3.6? - k [Shengzhou] Yes. Greg, ping? - k ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 2/2] powerpc/usb: fix bug of CPU hang when missing USB PHY clock
On Fri, Aug 10, 2012 at 5:48 AM, Shengzhou Liu
shengzhou@freescale.com wrote:
+ for (timeout = 1000; timeout 0; timeout--) {
+ /* check PHY_CLK_VALID to get phy clk valid */
+ if (in_be32(non_ehci + FSL_SOC_USB_CTRL)
+PHY_CLK_VALID)
+ break;
+ udelay(1);
+ }
Use spin_event_timeout() instead.
--
Timur Tabi
Linux kernel developer at Freescale
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: [PATCH 2/2] powerpc/usb: fix bug of CPU hang when missing USB PHY clock
-Original Message- From: Kumar Gala [mailto:ga...@kernel.crashing.org] Sent: Friday, August 10, 2012 9:50 PM To: Liu Shengzhou-B36685 Cc: linuxppc-dev@lists.ozlabs.org list; linux-...@vger.kernel.org; gre...@linuxfoundation.org Subject: Re: [PATCH 2/2] powerpc/usb: fix bug of CPU hang when missing USB PHY clock On Aug 10, 2012, at 5:48 AM, Shengzhou Liu wrote: when missing USB PHY clock, kernel booting up will hang during USB initialization. We should check USBGP[PHY_CLK_VALID] bit to avoid CPU hanging in this case. Signed-off-by: Shengzhou Liu shengzhou@freescale.com --- drivers/usb/host/ehci-fsl.c | 63 ++--- - drivers/usb/host/ehci-fsl.h |1 + 2 files changed, 46 insertions(+), 18 deletions(-) I assume this should be considered a bug fix and be looked at for inclusion in v3.6? - k [Shengzhou] Yes. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 2/2] powerpc/usb: fix bug of CPU hang when missing USB PHY clock
On Aug 10, 2012, at 5:48 AM, Shengzhou Liu wrote: when missing USB PHY clock, kernel booting up will hang during USB initialization. We should check USBGP[PHY_CLK_VALID] bit to avoid CPU hanging in this case. Signed-off-by: Shengzhou Liu shengzhou@freescale.com --- drivers/usb/host/ehci-fsl.c | 63 ++ drivers/usb/host/ehci-fsl.h |1 + 2 files changed, 46 insertions(+), 18 deletions(-) I assume this should be considered a bug fix and be looked at for inclusion in v3.6? - k ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
