Re: [PATCH 2/3] cxl: Introduce module parameter 'enable_psltrace'

2018-02-13 Thread Vaibhav Jain
Frederic Barrat writes: > Le 11/02/2018 à 18:10, Vaibhav Jain a écrit : >> Thanks for reviewing the patch Christophe, >> >> christophe lombard writes: +bool cxl_enable_psltrace = true; +module_param_named(enable_psltrace, cxl_enable_psltrace, bool, 0600); +MODULE_PARM_DESC(enable

Re: [PATCH 2/3] cxl: Introduce module parameter 'enable_psltrace'

2018-02-12 Thread Frederic Barrat
Le 11/02/2018 à 18:10, Vaibhav Jain a écrit : Thanks for reviewing the patch Christophe, christophe lombard writes: +bool cxl_enable_psltrace = true; +module_param_named(enable_psltrace, cxl_enable_psltrace, bool, 0600); +MODULE_PARM_DESC(enable_psltrace, "Set PSL traces on probe. default: o

Re: [PATCH 2/3] cxl: Introduce module parameter 'enable_psltrace'

2018-02-12 Thread christophe lombard
Le 11/02/2018 à 18:10, Vaibhav Jain a écrit : Thanks for reviewing the patch Christophe, christophe lombard writes: +bool cxl_enable_psltrace = true; +module_param_named(enable_psltrace, cxl_enable_psltrace, bool, 0600); +MODULE_PARM_DESC(enable_psltrace, "Set PSL traces on probe. default: on"

Re: [PATCH 2/3] cxl: Introduce module parameter 'enable_psltrace'

2018-02-11 Thread Vaibhav Jain
Thanks for reviewing the patch Christophe, christophe lombard writes: >> +bool cxl_enable_psltrace = true; >> +module_param_named(enable_psltrace, cxl_enable_psltrace, bool, 0600); >> +MODULE_PARM_DESC(enable_psltrace, "Set PSL traces on probe. default: on"); >> + > I am not too agree to add a ne

Re: [PATCH 2/3] cxl: Introduce module parameter 'enable_psltrace'

2018-02-09 Thread christophe lombard
Le 09/02/2018 à 05:25, Vaibhav Jain a écrit : We introduce a new module parameter named 'enable_psltrace' which asks cxl to start(by default) psl-traces on an adapter as soon as its probe is finished. In case this default behavior is not needed then this module parameter can be set to '0'. Signe