Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-16 Thread Arnd Bergmann
On Thu, Jun 16, 2022 at 7:42 AM Rohan McLure wrote: > > As for SPU's, the issue here is that include/linux/syscalls.h only > provides prototypes for sys_... handlers. So spu_callbacks.c must > reference these symbols for the translation unit to compile. A solution > may be for spu_syscall_table

Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-15 Thread Rohan McLure
> Le 01/06/2022 à 10:29, Christophe Leroy a écrit : >> Le 01/06/2022 à 07:48, Rohan McLure a écrit : >>> [Vous ne recevez pas souvent de courriers de la part de >>> rmcl...@linux.ibm.com. Découvrez pourquoi cela peut être important à >>> l'adresse https://aka.ms/LearnAboutSenderIdentification.]

Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-15 Thread Arnd Bergmann
On Wed, Jun 15, 2022 at 3:47 AM Rohan McLure wrote: > > On 3 Jun 2022, at 7:04 pm, Arnd Bergmann wrote: > > On Wed, Jun 1, 2022 at 7:48 AM Rohan McLure wrote: > > What is the benefit of having a separate set of macros for this? I think > > that > > adds more complexity than it saves in the

Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-14 Thread Rohan McLure
> On 3 Jun 2022, at 7:04 pm, Arnd Bergmann wrote: > > On Wed, Jun 1, 2022 at 7:48 AM Rohan McLure wrote: >> >> Syscall wrapper implemented as per s390, x86, arm64, providing the >> option for gprs to be cleared on entry to the kernel, reducing caller >> influence influence on speculation

Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-14 Thread Andrew Donnellan
On Fri, 2022-06-03 at 08:39 +, Christophe Leroy wrote: > > > Le 03/06/2022 à 09:09, Andrew Donnellan a écrit : > > On Fri, 2022-06-03 at 13:24 +1000, Rohan McLure wrote: > > > The implementation of ppc_personality can be immediately reworked > > > to > > > call ksys_personality, but I can’t

Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-09 Thread Christophe Leroy
Le 01/06/2022 à 10:29, Christophe Leroy a écrit : Le 01/06/2022 à 07:48, Rohan McLure a écrit : [Vous ne recevez pas souvent de courriers de la part de rmcl...@linux.ibm.com. Découvrez pourquoi cela peut être important à l'adresse https://aka.ms/LearnAboutSenderIdentification.] Syscall

Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-03 Thread Arnd Bergmann
On Wed, Jun 1, 2022 at 7:48 AM Rohan McLure wrote: > > Syscall wrapper implemented as per s390, x86, arm64, providing the > option for gprs to be cleared on entry to the kernel, reducing caller > influence influence on speculation within syscall routine. The wrapper > is a macro that emits

Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-03 Thread Christophe Leroy
Le 03/06/2022 à 09:09, Andrew Donnellan a écrit : > On Fri, 2022-06-03 at 13:24 +1000, Rohan McLure wrote: >> The implementation of ppc_personality can be immediately reworked to >> call ksys_personality, but I can’t do the same for sys_old_select for >> example, which is required to implement

Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-03 Thread Andrew Donnellan
On Fri, 2022-06-03 at 13:24 +1000, Rohan McLure wrote: > The implementation of ppc_personality can be immediately reworked to > call ksys_personality, but I can’t do the same for sys_old_select for > example, which is required to implement ppc_select. As such we emit > both For ppc_select, I

Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-02 Thread Rohan McLure
Thanks for your comment. I comment briefly here on how files like arch/powerpc/kernel/syscalls.c implement ppc specialisations of various syscalls, with implementations that themselves call syscall symbols. >> For platforms supporting this syscall wrapper, emit symbols with usual >> in-register

Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-01 Thread Christophe Leroy
Le 01/06/2022 à 07:48, Rohan McLure a écrit : > [Vous ne recevez pas souvent de courriers de la part de > rmcl...@linux.ibm.com. Découvrez pourquoi cela peut être important à > l'adresse https://aka.ms/LearnAboutSenderIdentification.] > > Syscall wrapper implemented as per s390, x86, arm64,

Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-01 Thread kernel test robot
Hi Rohan, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.18] [also build test ERROR on next-20220601] [cannot apply to powerpc/next scottwood/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-01 Thread kernel test robot
Hi Rohan, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.18] [also build test ERROR on next-20220601] [cannot apply to powerpc/next scottwood/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-01 Thread kernel test robot
Hi Rohan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v5.18] [also build test WARNING on next-20220601] [cannot apply to powerpc/next scottwood/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH 2/6] powerpc: Provide syscall wrapper

2022-06-01 Thread Christophe Leroy
Le 01/06/2022 à 07:48, Rohan McLure a écrit : > [Vous ne recevez pas souvent de courriers de la part de > rmcl...@linux.ibm.com. Découvrez pourquoi cela peut être important à > l'adresse https://aka.ms/LearnAboutSenderIdentification.] > > Syscall wrapper implemented as per s390, x86, arm64,