Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling

2020-06-01 Thread Finn Thain
On Mon, 1 Jun 2020, Geert Uytterhoeven wrote: > > > > Sure, it could be absorbed by both asm/mac_iop.h and > > drivers/macintosh/adb-iop.c [...] > > asm/mac_iop.h doesn't include asm/adb_iop.h (at least not in my tree, > but perhaps you have plans to change that?), so there's only a single >

Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling

2020-06-01 Thread Geert Uytterhoeven
Hi Finn, On Mon, Jun 1, 2020 at 2:15 AM Finn Thain wrote: > On Sun, 31 May 2020, Geert Uytterhoeven wrote: > > On Sun, May 31, 2020 at 1:20 AM Finn Thain > > wrote: > > > arch/m68k/include/asm/adb_iop.h | 1 + > > > drivers/macintosh/adb-iop.c | 32 ++-- > > >

Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling

2020-06-01 Thread Geert Uytterhoeven
Hi Brad, On Sun, May 31, 2020 at 10:01 PM Brad Boyer wrote: > On Sun, May 31, 2020 at 10:38:04AM +0200, Geert Uytterhoeven wrote: > > > arch/m68k/include/asm/adb_iop.h | 1 + > > As this header file is used by a single source file only, perhaps it should > > just be absorbed by the latter? > >

Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling

2020-05-31 Thread Finn Thain
On Sun, 31 May 2020, Geert Uytterhoeven wrote: > Hi Finn, > > On Sun, May 31, 2020 at 1:20 AM Finn Thain wrote: > > The adb_driver.autopoll method is needed during ADB bus scan and device > > address assignment. Implement this method so that the IOP's list of > > device addresses can be

Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling

2020-05-31 Thread Brad Boyer
On Sun, May 31, 2020 at 10:38:04AM +0200, Geert Uytterhoeven wrote: > > arch/m68k/include/asm/adb_iop.h | 1 + > > As this header file is used by a single source file only, perhaps it should > just be absorbed by the latter? > Then you no longer need my Acked-by for future changes ;-) While I

Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling

2020-05-31 Thread Geert Uytterhoeven
Hi Finn, On Sun, May 31, 2020 at 1:20 AM Finn Thain wrote: > The adb_driver.autopoll method is needed during ADB bus scan and device > address assignment. Implement this method so that the IOP's list of > device addresses can be updated. When the list is empty, disable SRQ > autopolling. > > Cc: