Re: [PATCH net-next 0/6] Remove VLAN.CFI overload
On 11/10/2018 10:47 PM, David Miller wrote: > From: Michał Mirosław > Date: Sat, 10 Nov 2018 19:58:29 +0100 > >> Fix BPF code/JITs to allow for separate VLAN_PRESENT flag >> storage and finally move the flag to separate storage in skbuff. >> >> This is final step to make CLAN.CFI transparent to core Linux >> networking stack. >> >> An #ifdef is introduced temporarily to mark fragments masking >> VLAN_TAG_PRESENT. This is removed altogether in the final patch. > > Daniel and Alexei, please review. Sorry, was completely swamped due to plumbers, just getting to it now.
Re: [PATCH net-next 0/6] Remove VLAN.CFI overload
From: Alexei Starovoitov Date: Fri, 16 Nov 2018 19:51:55 -0800 > Michal, could you please explain the reasoning? By treating VLAN.CFI specially as "VLAN TAG PRESENT" we prevent the usage of certain VLAN ID encodings. So he's trying to get rid of VLAN_TAG_PRESENT completely and this was the final patch series necessary to accomplish that.
Re: [PATCH net-next 0/6] Remove VLAN.CFI overload
On Sat, Nov 10, 2018 at 1:48 PM David Miller wrote: > > From: Michał Mirosław > Date: Sat, 10 Nov 2018 19:58:29 +0100 > > > Fix BPF code/JITs to allow for separate VLAN_PRESENT flag > > storage and finally move the flag to separate storage in skbuff. > > > > This is final step to make CLAN.CFI transparent to core Linux > > networking stack. > > > > An #ifdef is introduced temporarily to mark fragments masking > > VLAN_TAG_PRESENT. This is removed altogether in the final patch. > > Daniel and Alexei, please review. It was on my todo list. All reviews got delayed due to LPC. I guess too late to comment now. Anyhow I don't see the value in this patch set. Seems like code churn. Michal, could you please explain the reasoning?
Re: [PATCH net-next 0/6] Remove VLAN.CFI overload
From: Michał Mirosław Date: Sat, 10 Nov 2018 19:58:29 +0100 > Fix BPF code/JITs to allow for separate VLAN_PRESENT flag > storage and finally move the flag to separate storage in skbuff. > > This is final step to make CLAN.CFI transparent to core Linux > networking stack. > > An #ifdef is introduced temporarily to mark fragments masking > VLAN_TAG_PRESENT. This is removed altogether in the final patch. Series applied, thank you.
Re: [PATCH net-next 0/6] Remove VLAN.CFI overload
From: Michał Mirosław Date: Sat, 10 Nov 2018 19:58:29 +0100 > Fix BPF code/JITs to allow for separate VLAN_PRESENT flag > storage and finally move the flag to separate storage in skbuff. > > This is final step to make CLAN.CFI transparent to core Linux > networking stack. > > An #ifdef is introduced temporarily to mark fragments masking > VLAN_TAG_PRESENT. This is removed altogether in the final patch. Daniel and Alexei, please review.
