Re: [PATCH v2] powerpc: Fix compile issue with force DAWR

2019-05-14 Thread Christophe Leroy
Le 14/05/2019 à 08:55, Michael Neuling a écrit : [...] + +static ssize_t dawr_write_file_bool(struct file *file, + const char __user *user_buf, + size_t count, loff_t *ppos) +{ + struct arch_hw_breakpoint

Re: [PATCH v2] powerpc: Fix compile issue with force DAWR

2019-05-14 Thread Michael Neuling
> > > > -- > > > > v2: > > > > Fixes based on Christophe Leroy's comments: > > > > - Fix commit message formatting > > > > - Move more DAWR code into dawr.c > > > > --- > > > >arch/powerpc/Kconfig | 5 ++ > > > >arch/powerpc/include/asm/hw_breakpoint.h |

Re: [PATCH v2] powerpc: Fix compile issue with force DAWR

2019-05-13 Thread Christophe Leroy
Le 14/05/2019 à 06:47, Michael Neuling a écrit : On Mon, 2019-05-13 at 11:08 +0200, Christophe Leroy wrote: Le 13/05/2019 à 09:17, Michael Neuling a écrit : If you compile with KVM but without CONFIG_HAVE_HW_BREAKPOINT you fail at linking with:

Re: [PATCH v2] powerpc: Fix compile issue with force DAWR

2019-05-13 Thread Michael Neuling
On Mon, 2019-05-13 at 11:08 +0200, Christophe Leroy wrote: > > Le 13/05/2019 à 09:17, Michael Neuling a écrit : > > If you compile with KVM but without CONFIG_HAVE_HW_BREAKPOINT you fail > > at linking with: > >arch/powerpc/kvm/book3s_hv_rmhandlers.o:(.text+0x708): undefined > > reference to

Re: [PATCH v2] powerpc: Fix compile issue with force DAWR

2019-05-13 Thread Christophe Leroy
Le 13/05/2019 à 09:17, Michael Neuling a écrit : If you compile with KVM but without CONFIG_HAVE_HW_BREAKPOINT you fail at linking with: arch/powerpc/kvm/book3s_hv_rmhandlers.o:(.text+0x708): undefined reference to `dawr_force_enable' This was caused by commit c1fe190c0672 ("powerpc: Add