Re: [PATCH v2 1/2] mm: introduce ARCH_HAS_PTE_SPECIAL
On Tue, 10 Apr 2018, Laurent Dufour wrote: > > On Tue, Apr 10, 2018 at 05:25:50PM +0200, Laurent Dufour wrote: > >> arch/powerpc/include/asm/pte-common.h | 3 --- > >> arch/riscv/Kconfig | 1 + > >> arch/s390/Kconfig | 1 + > > > > You forgot to delete __HAVE_ARCH_PTE_SPECIAL from > > arch/riscv/include/asm/pgtable-bits.h > > Damned ! > Thanks for catching it. > Squashing the two patches together at least allowed it to be caught easily. After it's fixed, feel free to add Acked-by: David Rientjes Thanks for doing this!
Re: [PATCH v2 1/2] mm: introduce ARCH_HAS_PTE_SPECIAL
On Tue, 10 Apr 2018 09:09:32 PDT (-0700), wi...@infradead.org wrote: On Tue, Apr 10, 2018 at 05:25:50PM +0200, Laurent Dufour wrote: arch/powerpc/include/asm/pte-common.h | 3 --- arch/riscv/Kconfig | 1 + arch/s390/Kconfig | 1 + You forgot to delete __HAVE_ARCH_PTE_SPECIAL from arch/riscv/include/asm/pgtable-bits.h Thanks -- I was looking for that but couldn't find it and assumed I'd just misunderstood something.
Re: [PATCH v2 1/2] mm: introduce ARCH_HAS_PTE_SPECIAL
On 10/04/2018 18:09, Matthew Wilcox wrote: > On Tue, Apr 10, 2018 at 05:25:50PM +0200, Laurent Dufour wrote: >> arch/powerpc/include/asm/pte-common.h | 3 --- >> arch/riscv/Kconfig | 1 + >> arch/s390/Kconfig | 1 + > > You forgot to delete __HAVE_ARCH_PTE_SPECIAL from > arch/riscv/include/asm/pgtable-bits.h Damned ! Thanks for catching it.
Re: [PATCH v2 1/2] mm: introduce ARCH_HAS_PTE_SPECIAL
On Tue, Apr 10, 2018 at 05:25:50PM +0200, Laurent Dufour wrote: > arch/powerpc/include/asm/pte-common.h | 3 --- > arch/riscv/Kconfig | 1 + > arch/s390/Kconfig | 1 + You forgot to delete __HAVE_ARCH_PTE_SPECIAL from arch/riscv/include/asm/pgtable-bits.h