Re: [PATCH v2 2/4] Implement generic time of day clocksource for powerpc machines.

2007-09-21 Thread David Gibson
On Fri, Sep 21, 2007 at 02:59:31PM +1000, Paul Mackerras wrote: Daniel Walker writes: I don't think the RTC frequency isn't the same as the timebase? Seems like the RTC only case about seconds at the lowest level. If that's the case then the jiffies clock might be better to use .. The

Re: [PATCH v2 2/4] Implement generic time of day clocksource for powerpc machines.

2007-09-21 Thread Tony Breeds
On Fri, Sep 21, 2007 at 02:52:12PM +1000, Stephen Rothwell wrote: Small comments. Thanks. I think this is redundant as if __USE_RTC() is true, you register clocksource_rtc below. Yup you're right. The #ifdef is redundant since if CONFIG_ISERIES is not set,

Re: [PATCH v2 2/4] Implement generic time of day clocksource for powerpc machines.

2007-09-20 Thread Daniel Walker
On Fri, 2007-09-21 at 13:26 +1000, Tony Breeds wrote: + + if (__USE_RTC()) + clock = clocksource_rtc; + else + clock = clocksource_timebase; + + clock-mult = clocksource_hz2mult(tb_ticks_per_sec, clock-shift); I don't think the RTC frequency

Re: [PATCH v2 2/4] Implement generic time of day clocksource for powerpc machines.

2007-09-20 Thread Paul Mackerras
Daniel Walker writes: I don't think the RTC frequency isn't the same as the timebase? Seems like the RTC only case about seconds at the lowest level. If that's the case then the jiffies clock might be better to use .. The other thing I wonder is if the __USE_RTC boards might have lower level