Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/30/16 at 01:08pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 11:41:19 schrieb Dave Young: > > On 06/29/16 at 06:09pm, Thiago Jung Bauermann wrote: > > > Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > > > > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > >

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-30 Thread Thiago Jung Bauermann
Am Donnerstag, 30 Juni 2016, 11:41:19 schrieb Dave Young: > On 06/29/16 at 06:09pm, Thiago Jung Bauermann wrote: > > Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > > > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > > > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: >

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/29/16 at 06:09pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > > > > On 06/27/16 at 04:21pm, Dave Young wrote: > > > > Using one

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-29 Thread Thiago Jung Bauermann
Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > > > On 06/27/16 at 04:21pm, Dave Young wrote: > > > Using one argument for both sounds more reasonable than using a > > >

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-29 Thread Dave Young
On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > > On 06/27/16 at 04:21pm, Dave Young wrote: > > > Please ignore previous reply, I mistakenly send a broken mail without > > > subject, sorry about it. Resend the reply here. > > > > >

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-28 Thread Thiago Jung Bauermann
Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > On 06/27/16 at 04:21pm, Dave Young wrote: > > Please ignore previous reply, I mistakenly send a broken mail without > > subject, sorry about it. Resend the reply here. > > > > On 06/27/16 at 01:37pm, Thiago Jung Bauermann wrote: > > > Am

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-28 Thread Dave Young
On 06/27/16 at 04:21pm, Dave Young wrote: > Please ignore previous reply, I mistakenly send a broken mail without > subject, sorry about it. Resend the reply here. > > On 06/27/16 at 01:37pm, Thiago Jung Bauermann wrote: > > Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave Young: > > > On

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-27 Thread Dave Young
Please ignore previous reply, I mistakenly send a broken mail without subject, sorry about it. Resend the reply here. On 06/27/16 at 01:37pm, Thiago Jung Bauermann wrote: > Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave Young: > > On 06/23/16 at 12:37pm, Thiago Jung Bauermann wrote: > > > Am

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-27 Thread Thiago Jung Bauermann
Am Montag, 27 Juni 2016, 13:37:58 schrieb Thiago Jung Bauermann: > Should I add a separate top_down argument to kexec_locate_mem_hole to > control if the memory walk should be from top to bottom, and then the > bottom_up member of struct kexec_buf controls where inside each memory > region the

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-27 Thread Thiago Jung Bauermann
Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave Young: > On 06/23/16 at 12:37pm, Thiago Jung Bauermann wrote: > > Am Donnerstag, 23 Juni 2016, 01:44:07 schrieb Dave Young: > > What is bad about the description of top_down? > It is not clear enough to me, I personally think the original one in >

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-27 Thread Dave Young
On 06/23/16 at 12:37pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 23 Juni 2016, 01:44:07 schrieb Dave Young: > > Hmm, hold on. For declaring a struct in a header file, comment should be > > just after each fields, like below, your format is for a function instead: > > struct pci_slot { > >

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-23 Thread Thiago Jung Bauermann
Am Donnerstag, 23 Juni 2016, 01:44:07 schrieb Dave Young: > Hmm, hold on. For declaring a struct in a header file, comment should be > just after each fields, like below, your format is for a function instead: > struct pci_slot { > struct pci_bus *bus;/* The bus this slot is on

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
sion.com> Sent: Thursday, June 23, 2016 10:30:52 AM Subject: Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer. On 06/22/16 at 08:34pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 22 Juni 2016, 18:18:01 schrieb Dave Young: >

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
On 06/22/16 at 08:34pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 22 Juni 2016, 18:18:01 schrieb Dave Young: > > On 06/21/16 at 04:48pm, Thiago Jung Bauermann wrote: > > > +/** > > > + * kexec_locate_mem_hole - find free memory to load segment or use in > > > purgatory + * @image: kexec

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Thiago Jung Bauermann
Am Mittwoch, 22 Juni 2016, 18:18:01 schrieb Dave Young: > On 06/21/16 at 04:48pm, Thiago Jung Bauermann wrote: > > +/** > > + * kexec_locate_mem_hole - find free memory to load segment or use in > > purgatory + * @image: kexec image being updated. > > + * @size: Memory size. > > + * @align:

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
On 06/21/16 at 04:48pm, Thiago Jung Bauermann wrote: > kexec_locate_mem_hole will be used by the PowerPC kexec_file_load > implementation to find free memory for the purgatory stack. > > Signed-off-by: Thiago Jung Bauermann > Cc: Eric Biederman