On Thu, 22 Feb 2018 15:27:24 +0100 (CET) Christophe Leroy <christophe.le...@c-s.fr> wrote:
> In preparation for the following patch which will fix an issue on > the 8xx by re-using the 'slices', this patch enhances the > 'slices' implementation to support 32 bits CPUs. > > On PPC32, the address space is limited to 4Gbytes, hence only the low > slices will be used. > > The high slices use bitmaps. As bitmap functions are not prepared to > handle bitmaps of size 0, this patch ensures that bitmap functions > are called only when SLICE_NUM_HIGH is not nul. > > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> This looks good to me, thank you for taking my feedback into account. Is the patch split and naming good? Yes I guess so, this adds support for ppc32 archs that select PPC_MM_SLICES, and the next one implements it for 8xx. There looks to be some generic arch/powerpc/mm bits in the next patch. I wonder if you would move them over? Then the next patch could be called powerpc/8xx: ? Anyway it's not a big deal. Reviewed-by: Nicholas Piggin <npig...@gmail.com>