Re: [RFC PATCH 3/5] powerpc: sstep: Add instruction emulation selftests

2019-02-11 Thread Sandipan Das
On 11/02/19 6:17 AM, Daniel Axtens wrote: > Hi Sandipan, > > I'm not really confident to review the asm, but I did have a couple of > questions about the C: > >> +#define MAX_INSNS 32 > This doesn't seem to be used... > True. Thanks for pointing this out. >> +int execute_instr(struct

Re: [RFC PATCH 3/5] powerpc: sstep: Add instruction emulation selftests

2019-02-10 Thread Daniel Axtens
Hi Sandipan, I'm not really confident to review the asm, but I did have a couple of questions about the C: > +#define MAX_INSNS32 This doesn't seem to be used... > +int execute_instr(struct pt_regs *regs, unsigned int instr) > +{ > + extern unsigned int exec_instr_execute[]; > +