Re: [RFC PATCH 5/6] powerpc/microwatt: select POWER9_CPU

2021-08-30 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of August 28, 2021 7:50 pm:
> 
> 
> Le 27/08/2021 à 18:34, Nicholas Piggin a écrit :
>> Microwatt implements a subset of ISA v3.0 which is equivalent to
>> the POWER9_CPU selection.
>> 
>> Signed-off-by: Nicholas Piggin 
>> ---
>>   arch/powerpc/configs/microwatt_defconfig | 1 +
>>   arch/powerpc/platforms/microwatt/Kconfig | 1 +
>>   2 files changed, 2 insertions(+)
>> 
>> diff --git a/arch/powerpc/configs/microwatt_defconfig 
>> b/arch/powerpc/configs/microwatt_defconfig
>> index a08b739123da..bf5f2e5905eb 100644
>> --- a/arch/powerpc/configs/microwatt_defconfig
>> +++ b/arch/powerpc/configs/microwatt_defconfig
>> @@ -14,6 +14,7 @@ CONFIG_EMBEDDED=y
>>   # CONFIG_COMPAT_BRK is not set
>>   # CONFIG_SLAB_MERGE_DEFAULT is not set
>>   CONFIG_PPC64=y
>> +CONFIG_POWER9_CPU=y
> 
> That shouldn't be needed in the defconfig because you select it below. You 
> can use make 
> savedefconfig to confirm.

Good point.

Thanks,
Nick


Re: [RFC PATCH 5/6] powerpc/microwatt: select POWER9_CPU

2021-08-28 Thread Christophe Leroy




Le 27/08/2021 à 18:34, Nicholas Piggin a écrit :

Microwatt implements a subset of ISA v3.0 which is equivalent to
the POWER9_CPU selection.

Signed-off-by: Nicholas Piggin 
---
  arch/powerpc/configs/microwatt_defconfig | 1 +
  arch/powerpc/platforms/microwatt/Kconfig | 1 +
  2 files changed, 2 insertions(+)

diff --git a/arch/powerpc/configs/microwatt_defconfig 
b/arch/powerpc/configs/microwatt_defconfig
index a08b739123da..bf5f2e5905eb 100644
--- a/arch/powerpc/configs/microwatt_defconfig
+++ b/arch/powerpc/configs/microwatt_defconfig
@@ -14,6 +14,7 @@ CONFIG_EMBEDDED=y
  # CONFIG_COMPAT_BRK is not set
  # CONFIG_SLAB_MERGE_DEFAULT is not set
  CONFIG_PPC64=y
+CONFIG_POWER9_CPU=y


That shouldn't be needed in the defconfig because you select it below. You can use make 
savedefconfig to confirm.



  # CONFIG_PPC_KUEP is not set
  # CONFIG_PPC_KUAP is not set
  CONFIG_CPU_LITTLE_ENDIAN=y
diff --git a/arch/powerpc/platforms/microwatt/Kconfig 
b/arch/powerpc/platforms/microwatt/Kconfig
index 823192e9d38a..e0ff2cfc1ca0 100644
--- a/arch/powerpc/platforms/microwatt/Kconfig
+++ b/arch/powerpc/platforms/microwatt/Kconfig
@@ -2,6 +2,7 @@
  config PPC_MICROWATT
depends on PPC_BOOK3S_64 && !SMP
bool "Microwatt SoC platform"
+   select POWER9_CPU
select PPC_XICS
select PPC_ICS_NATIVE
select PPC_ICP_NATIVE