Re: [tpmdd-devel] [PATCH] TPM: Provide a tpm_tis OF driver

[Rajiv Andrade]

Just a minor comment

On Tue, 2010-03-09 at 13:01 -0700, Jason Gunthorpe wrote:

 @@ -703,7 +747,17 @@ static int __init init_tis(void)
   return rc;
   }
 
 - return pnp_register_driver(tis_pnp_driver);
 +#ifdef CONFIG_OF
 + rc = of_register_platform_driver(tis_of_driver);
 + if (rc)
 + return rc;
 +#endif
 +#ifdef CONFIG_PNP
 + rc = pnp_register_driver(tis_pnp_driver);
 + if (rc)
 + return rc;
 +#endif
 + return 0;
  }
 

Why not 

+#ifdef CONFIG_OF
+   return of_register_platform_driver(tis_of_driver);
+#elif CONFIG_PNP
+   return pnp_register_driver(tis_pnp_driver);
+#endif

?

Other than this it looks nice.

Acked-by: Rajiv Andrade sra...@linux.vnet.ibm.com


Thanks,
Rajiv

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [tpmdd-devel] [PATCH] TPM: Provide a tpm_tis OF driver

[Jason Gunthorpe]

On Thu, Mar 25, 2010 at 01:20:41AM -0300, Rajiv Andrade wrote:

 Why not 
 
 +#ifdef CONFIG_OF
 + return of_register_platform_driver(tis_of_driver);
 +#elif CONFIG_PNP
 + return pnp_register_driver(tis_pnp_driver);
 +#endif
 
 ?

AFAIK they are not exclusive options? I can't imagine anyone building
a kernel with both, but the rest of the patch is designed to allow
both at once..

 Acked-by: Rajiv Andrade sra...@linux.vnet.ibm.com

Thanks - who can pick this up to feed it upstream?

Jason
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev