Re: Infinite looping observed in __offline_pages

2018-08-23 Thread Michal Hocko
On Wed 22-08-18 11:58:02, Mike Kravetz wrote: > On 08/22/2018 02:30 AM, Aneesh Kumar K.V wrote: [...] > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > > index 4eb6e824a80c..f9bdea685cf4 100644 > > --- a/mm/memory_hotplug.c > > +++ b/mm/memory_hotplug.c > > @@ -1338,7 +1338,8 @@ static

Re: Infinite looping observed in __offline_pages

2018-08-22 Thread Aneesh Kumar K.V
On 08/23/2018 12:28 AM, Mike Kravetz wrote: On 08/22/2018 02:30 AM, Aneesh Kumar K.V wrote: commit 2e9d754ac211f2af3731f15df3cd8cd070b4cc54 Author: Aneesh Kumar K.V Date: Tue Aug 21 14:17:55 2018 +0530 mm/hugetlb: filter out hugetlb pages if HUGEPAGE migration is not supported.

Re: Infinite looping observed in __offline_pages

2018-08-22 Thread Mike Kravetz
On 08/22/2018 02:30 AM, Aneesh Kumar K.V wrote: > commit 2e9d754ac211f2af3731f15df3cd8cd070b4cc54 > Author: Aneesh Kumar K.V > Date: Tue Aug 21 14:17:55 2018 +0530 > > mm/hugetlb: filter out hugetlb pages if HUGEPAGE migration is not > supported. > > When scanning for movable

Re: Infinite looping observed in __offline_pages

2018-08-22 Thread Michal Hocko
On Wed 22-08-18 15:00:18, Aneesh Kumar K.V wrote: > > Hi Michal, > > Michal Hocko writes: > > > On Wed 25-07-18 13:11:15, John Allen wrote: > > [...] > >> Does a failure in do_migrate_range indicate that the range is unmigratable > >> and the loop in __offline_pages should terminate and goto

Re: Infinite looping observed in __offline_pages

2018-08-22 Thread Aneesh Kumar K.V
Hi Michal, Michal Hocko writes: > On Wed 25-07-18 13:11:15, John Allen wrote: > [...] >> Does a failure in do_migrate_range indicate that the range is unmigratable >> and the loop in __offline_pages should terminate and goto failed_removal? Or >> should we allow a certain number of retrys

Re: Infinite looping observed in __offline_pages

2018-08-01 Thread Michal Hocko
On Wed 01-08-18 21:09:39, Michael Ellerman wrote: > Michal Hocko writes: > > On Wed 25-07-18 13:11:15, John Allen wrote: > > [...] > >> Does a failure in do_migrate_range indicate that the range is unmigratable > >> and the loop in __offline_pages should terminate and goto failed_removal? > >>

Re: Infinite looping observed in __offline_pages

2018-08-01 Thread Michael Ellerman
Michal Hocko writes: > On Wed 25-07-18 13:11:15, John Allen wrote: > [...] >> Does a failure in do_migrate_range indicate that the range is unmigratable >> and the loop in __offline_pages should terminate and goto failed_removal? Or >> should we allow a certain number of retrys before we >> give

Re: Infinite looping observed in __offline_pages

2018-07-31 Thread Rashmica
On 26/07/18 04:11, John Allen wrote: > Hi All, > > Under heavy stress and constant memory hot add/remove, I have observed > the following loop to occasionally loop infinitely: > > mm/memory_hotplug.c:__offline_pages > > repeat: >    /* start memory hot removal */ >    ret = -EINTR; >    

Re: Infinite looping observed in __offline_pages

2018-07-30 Thread Michal Hocko
On Fri 27-07-18 12:32:59, John Allen wrote: > On Wed, Jul 25, 2018 at 10:03:36PM +0200, Michal Hocko wrote: > > On Wed 25-07-18 13:11:15, John Allen wrote: > > [...] > > > Does a failure in do_migrate_range indicate that the range is unmigratable > > > and the loop in __offline_pages should

Re: Infinite looping observed in __offline_pages

2018-07-27 Thread John Allen
On Wed, Jul 25, 2018 at 10:03:36PM +0200, Michal Hocko wrote: On Wed 25-07-18 13:11:15, John Allen wrote: [...] Does a failure in do_migrate_range indicate that the range is unmigratable and the loop in __offline_pages should terminate and goto failed_removal? Or should we allow a certain

Re: Infinite looping observed in __offline_pages

2018-07-25 Thread Michal Hocko
On Wed 25-07-18 13:11:15, John Allen wrote: [...] > Does a failure in do_migrate_range indicate that the range is unmigratable > and the loop in __offline_pages should terminate and goto failed_removal? Or > should we allow a certain number of retrys before we > give up on migrating the range?