Re: linux-4.14-rc1/arch/powerpc/perf/hv-24x7.c:541: bad condition ?

2017-09-21 Thread Michael Ellerman
[ + Cody in case he's still interested] Michael Ellerman writes: > David Binderman writes: > >> Hello there, >> >> linux-4.14-rc1/arch/powerpc/perf/hv-24x7.c:543]: (warning) Identical >> condition 's1> >> Source

Re: linux-4.14-rc1/arch/powerpc/perf/hv-24x7.c:541: bad condition ?

2017-09-19 Thread Michael Ellerman
David Binderman writes: > Hello there, > > linux-4.14-rc1/arch/powerpc/perf/hv-24x7.c:543]: (warning) Identical > condition 's1 > Source code is > > if (s1 < s2) > return 1; > if (s2 > s1) > return -1; > >

linux-4.14-rc1/arch/powerpc/perf/hv-24x7.c:541: bad condition ?

2017-09-18 Thread David Binderman
Hello there, linux-4.14-rc1/arch/powerpc/perf/hv-24x7.c:543]: (warning) Identical condition 's1 s1) return -1; Suggest code rework. Regards David Binderman