On Mon, Mar 24, 2014 at 09:53:43AM +0100, Jiri Benc wrote:
> Require subscriptions to be renewed regularly. This way, the subscription
> automatically times out when phc2sys is killed.
Can't this patch go before all of the phc2sys stuff?
Thanks,
Richard
--
On Mon, Mar 24, 2014 at 09:53:43AM +0100, Jiri Benc wrote:
> Require subscriptions to be renewed regularly. This way, the subscription
> automatically times out when phc2sys is killed.
>
> Signed-off-by: Jiri Benc
> ---
> clock.c | 24
> phc2sys.c | 10 ++
>
On Mon, Mar 24, 2014 at 09:53:29AM +0100, Jiri Benc wrote:
> Will be used by phc2sys to find out interfaces corresponding to ports.
This looks okay to me. Same nits as before...
> Signed-off-by: Jiri Benc
> ---
> clock.c |9 +
> port.c | 16
> tlv.c | 20 +++
On Mon, Mar 24, 2014 at 09:53:28AM +0100, Jiri Benc wrote:
> Add an event number for port adding/removal. As currently the ports are
> static, this event is not emitted for now.
Then this patch should wait unit dynamic ports are ready.
Thanks,
Richard
---
On Mon, Mar 24, 2014 at 09:53:27AM +0100, Jiri Benc wrote:
> Used to enumerate all ports. With the future dynamic port adding/removal,
> there may be holes in the port number sequence. For now, just fill it with
> the sequence numbers.
>
> Signed-off-by: Jiri Benc
> ---
> clock.c | 16
On Mon, Mar 24, 2014 at 09:53:23AM +0100, Jiri Benc wrote:
> The standard requires management TLV in replies to commands:
>
> An acknowledge management message is a response to a command
> management message. The value of the managementId shall be identical
> to that in the comma
On Mon, Mar 24, 2014 at 09:53:22AM +0100, Jiri Benc wrote:
> This puts groundwork for event subscription and notification. The individual
> events are added by subsequent patches.
This patch is basically okay, but I have to pick a few nits...
> +struct clock_subscriber {
> + LIST_ENTRY(clock
On Mon, Mar 24, 2014 at 09:53:21AM +0100, Jiri Benc wrote:
> When phc2sys is started before ptp4l or it is interrupted before ptp4l has
> a chance to reply to its query, the "uds: sendto failed: Connection refused"
> message is output. This is not an interesting message.
>
> Also, don't output the
I looked again at the unicast issue, and here is what I found.
* 1588 has a very complex unicast subscription protocol (16.1). This
is similar to what you have in this series, and so if we do it right
then we will have a good basis for adding this later.
* 1588 also allows basically any kind
On Mon, Mar 31, 2014 at 03:14:11PM +0200, Jiri Benc wrote:
>
> Has anybody have a chance to review this patchset? I'd appreciate any
> feedback.
I now have some cycles to work this in. It is a little too long of a
series for me to merge all at once. I would like to focus first on
patches 1-12. Pl
On Mon, Mar 24, 2014 at 09:53:19AM +0100, Jiri Benc wrote:
> The task of preparing the message for transmission and sending it appears
> at many places. Unify them into a new function.
>
> Signed-off-by: Jiri Benc
> ---
Applied.
Thanks,
Richard
-
On Mon, Mar 24, 2014 at 09:53:18AM +0100, Jiri Benc wrote:
> Currently, it is assumed that the management TLV data of management COMMAND
> messages is always empty. This is not true for the INITIALIZE command and
> also for a custom command we'll be introducing.
>
> Move the check to msg_post_recv
12 matches
Mail list logo
