Re: [Linuxptp-devel] [RFC Patch 2/2] port: Fix link down/up to continue using phc_index set from command line -p option.

2021-01-07 Thread Vincent Cheng
Hi Jacob, On Thu, Jan 07, 2021 at 02:33:56PM EST, Jacob Keller wrote: > > >On 1/6/2021 11:39 AM, vincent.cheng...@renesas.com wrote: >> >> diff --git a/port.c b/port.c >> index db3e9ac..bdc73e4 100644 >> --- a/port.c >> +++ b/port.c >> @@ -2568,7 +2568,8 @@ void port_link_status(void *ctx, int li

Re: [Linuxptp-devel] [RFC Patch 1/2] port: Add phc_from_cmdline to indicate the phc index was from the command line.

2021-01-07 Thread Vincent Cheng
Hi Jacob, On Thu, Jan 07, 2021 at 02:32:47PM EST, Jacob Keller wrote: > > >On 1/6/2021 11:39 AM, vincent.cheng...@renesas.com wrote: >> diff --git a/port_private.h b/port_private.h >> index fcabaa6..6e40e15 100644 >> --- a/port_private.h >> +++ b/port_private.h >> @@ -69,6 +69,7 @@ struct port { >

Re: [Linuxptp-devel] [RFC Patch 2/2] port: Fix link down/up to continue using phc_index set from command line -p option.

2021-01-07 Thread Jacob Keller
On 1/6/2021 11:39 AM, vincent.cheng...@renesas.com wrote: > From: Vincent Cheng > > In the scenario where a port link goes down and up, current code checks > the port's phc_index against the interface's phc_index and if they are > different will set the port phc_index to the interface phc_inde

Re: [Linuxptp-devel] [RFC Patch 1/2] port: Add phc_from_cmdline to indicate the phc index was from the command line.

2021-01-07 Thread Jacob Keller
On 1/6/2021 11:39 AM, vincent.cheng...@renesas.com wrote: > From: Vincent Cheng > > Signed-off-by: Vincent Cheng > --- > port_private.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/port_private.h b/port_private.h > index fcabaa6..6e40e15 100644 > --- a/port_private.h > +++ b/por

Re: [Linuxptp-devel] [PATCH v2 0/8] Convert to inclusive terminology, Part I

2021-01-07 Thread Jacob Keller
On 1/5/2021 6:42 AM, Richard Cochran wrote: > * Changed in v2: > - Use client/server terminology in the phc2sys man page. > - Add missing source/sink conversions in the phc2sys man page. > > > There is an industry wide effort underway to replace historically and > culturally loaded terms l

Re: [Linuxptp-devel] [PATCH v2 8/8] ts2phc: Convert usage message to time source/sink terminology.

2021-01-07 Thread Jacob Keller
On 1/5/2021 6:42 AM, Richard Cochran wrote: > Signed-off-by: Richard Cochran Reviewed-by: Jacob Keller > --- > ts2phc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ts2phc.c b/ts2phc.c > index 2342858..bc41041 100644 > --- a/ts2phc.c > +++ b/ts2phc.c > @@ -35,7

Re: [Linuxptp-devel] [PATCH v2 7/8] ptp4l: Convert usage messages to client/server terminology.

2021-01-07 Thread Jacob Keller
On 1/5/2021 6:42 AM, Richard Cochran wrote: > Signed-off-by: Richard Cochran Reviewed-by: Jacob Keller > --- > ptp4l.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ptp4l.c b/ptp4l.c > index 84661c5..ccbaa02 100644 > --- a/ptp4l.c > +++ b/ptp4l.c > @@ -58,7 +58,7

Re: [Linuxptp-devel] [PATCH v2 6/8] phc2sys: Convert usage messages to time source/sink terminology.

2021-01-07 Thread Jacob Keller
On 1/5/2021 6:42 AM, Richard Cochran wrote: > Signed-off-by: Richard Cochran Reviewed-by: Jacob Keller > --- > phc2sys.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/phc2sys.c b/phc2sys.c > index aafff6c..70155f9 100644 > --- a/phc2sys.c > +++ b/phc

Re: [Linuxptp-devel] [PATCH v2 5/8] ts2phc: Convert man page to source/sink terminology.

2021-01-07 Thread Jacob Keller
On 1/5/2021 6:42 AM, Richard Cochran wrote: > Signed-off-by: Richard Cochran Reviewed-by: Jacob Keller > --- > ts2phc.8 | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/ts2phc.8 b/ts2phc.8 > index 77f8940..0bd523d 100644 > --- a/ts2phc.8 > +++

Re: [Linuxptp-devel] [PATCH v2 4/8] ptp4l: Convert man page to client/server terminology.

2021-01-07 Thread Jacob Keller
On 1/5/2021 6:42 AM, Richard Cochran wrote: > Signed-off-by: Richard Cochran Reviewed-by: Jacob Keller > --- > ptp4l.8 | 80 + > 1 file changed, 41 insertions(+), 39 deletions(-) > > diff --git a/ptp4l.8 b/ptp4l.8 > index 473215b..42c

Re: [Linuxptp-devel] [PATCH v2 3/8] phc2sys: Convert man page to client/server terminology.

2021-01-07 Thread Jacob Keller
On 1/5/2021 6:42 AM, Richard Cochran wrote: > Signed-off-by: Richard Cochran Reviewed-by: Jacob Keller > --- > phc2sys.8 | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/phc2sys.8 b/phc2sys.8 > index 7773fd0..99fc937 100644 > --- a/phc2sys.8 > +++

Re: [Linuxptp-devel] [PATCH v2 2/8] phc2sys: Convert man page to source/sink terminology.

2021-01-07 Thread Jacob Keller
On 1/5/2021 6:42 AM, Richard Cochran wrote: > Signed-off-by: Richard Cochran > --- Makes sense. I like this direction for the terminology change. Reviewed-by: Jacob Keller > phc2sys.8 | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/phc2s

Re: [Linuxptp-devel] [PATCH v2 1/8] phc2sys: Update man page to reflect the new restriction on the PPS mode.

2021-01-07 Thread Jacob Keller
On 1/5/2021 6:42 AM, Richard Cochran wrote: > Signed-off-by: Richard Cochran > --- > phc2sys.8 | 16 > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/phc2sys.8 b/phc2sys.8 > index b3a3de3..66007eb 100644 > --- a/phc2sys.8 > +++ b/phc2sys.8 > @@ -1,4 +1,4 @@