Re: [Linuxptp-devel] [PATCH] Add UNICAST_MASTER_TABLE_NP management TLV

2022-02-17 Thread Richard Cochran
On Tue, Feb 15, 2022 at 10:55:45AM -0800, Alexander Bulimov via Linuxptp-devel wrote: > +struct UnicastMasterEntry { > + uint8_t selected; > + Enumeration8portState; > + struct PortIdentity portIdentity; > + struct ClockQuality clockQuality; >

Re: [Linuxptp-devel] [PATCH] servo: allows servo state transition back from S3 to S2

2022-02-17 Thread Richard Cochran
On Thu, Feb 17, 2022 at 11:24:00AM +0100, Luigi 'Comio' Mantellini wrote: > Dear All, > > I would like to advise that a transition from S3 (stable_lock) -> S2 (lock) > can create issues with Transient Noise or Transfer Noise behaviours when > write phase mode is also used. Good point. The S2 to

Re: [Linuxptp-devel] [PATCH] Add UNICAST_MASTER_TABLE_NP management TLV

2022-02-17 Thread Richard Cochran
On Tue, Feb 15, 2022 at 10:55:45AM -0800, Alexander Bulimov via Linuxptp-devel wrote: > 4857dd.fffe.0e91da-1 seq 0 RESPONSE MANAGEMENT > MID_UNICAST_MASTER_TABLE_NP > actualTableSize 9 > BM identity address >

Re: [Linuxptp-devel] [PATCHv5 0/2] ptp4l: add VLAN over bond support

2022-02-17 Thread Richard Cochran
On Thu, Feb 17, 2022 at 11:06:03AM +0800, Hangbin Liu wrote: > Hi Richard, > > Any update for this patchset? I've got some feedback coming... ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net

Re: [Linuxptp-devel] [PATCH] Add UNICAST_MASTER_TABLE_NP management TLV

2022-02-17 Thread Alexander Bulimov via Linuxptp-devel
Hi Erez, The standard indeed has UNICAST_MASTER_TABLE and ACCEPTABLE_MASTER_TABLE management TLVs defined, which as I've already mentioned are unfortunately useless for our use case. UNICAST_MASTER_TABLE exposes only a table of masters PortAddresses. There is nothing more - no identities, no

Re: [Linuxptp-devel] [PATCH] Add UNICAST_MASTER_TABLE_NP management TLV

2022-02-17 Thread Geva, Erez
Hi, The standard define: UNICAST_MASTER_TABLE ACCEPTABLE_MASTER_TABLE And some more tables. Why do we need a new private management TLV and not use the standard TLVs? Not against adding new management TLV, if we have good reason for. Nor do I think the standard is better. But it seems we skip

Re: [Linuxptp-devel] [PATCH] servo: allows servo state transition back from S3 to S2

2022-02-17 Thread Luigi 'Comio' Mantellini
Dear All, I would like to advise that a transition from S3 (stable_lock) -> S2 (lock) can create issues with Transient Noise or Transfer Noise behaviours when write phase mode is also used. I tried to introduce this transition in the past, but I was unable to choose the best threshold. In my