Re: [Linuxptp-devel] [PATCH v4] phc2sys: Add support for free-running mode

2022-07-25 Thread Richard Cochran
On Mon, Jul 25, 2022 at 03:25:11PM +0200, Maciek Machnikowski wrote: > Add support for the free-running mode that will not adjust the sink > clock when enabled. > > V2: changed implementation to instantiate NTPSHM servo that serves as > the nochange servo > V3: revert to original implementatio

Re: [Linuxptp-devel] [PATCH] G.8275.2 support for delay_mechanism NO_MECHANISM

2022-07-25 Thread Richard Cochran
On Mon, Jul 25, 2022 at 01:55:25PM +0530, SyncMonk Technologies wrote: > As per IEEE1588-2019, Table 21 adding NO_MECHANISM support. In this > case port does not implement the delay mechanism. > > Signed-off-by: Greg Armstrong > Signed-off-by: Leon Goldin > Signed-off-by: Devasish Dey > Signed-

Re: [Linuxptp-devel] [PATCH v2] port: Disable PHC switch with vclocks.

2022-07-25 Thread Richard Cochran
On Mon, Jul 25, 2022 at 09:57:07AM +0200, Miroslav Lichvar wrote: > With a virtual PHC, don't try to switch to the physical PHC after a > link-state change. JBOD and other multi-PHC configurations are not > supported with vclocks yet. > > Fixes: 9b9c2c58e6ed ("port: Check for virtual clocks.") >

Re: [Linuxptp-devel] [PATCH] unicast: Update announce timer when renew

2022-07-25 Thread Richard Cochran
On Tue, Jun 14, 2022 at 06:17:51AM -0700, Vadim Fedorenko via Linuxptp-devel wrote: > After first timeout of Announce message ptp4l will send Announce > requests messages to all of configured non-master clock peers > without updating timeout on approval packet making huge unneeded > workload on se

Re: [Linuxptp-devel] [PATCH] unicast: Update announce timer when renew

2022-07-25 Thread Richard Cochran
On Mon, Jul 25, 2022 at 10:07:16AM +0200, Miroslav Lichvar wrote: > On Sun, Jul 24, 2022 at 03:49:41PM -0700, Richard Cochran wrote: > > On Tue, Jun 14, 2022 at 06:17:51AM -0700, Vadim Fedorenko via > > Linuxptp-devel wrote: > > > @@ -467,6 +467,7 @@ void unicast_client_grant(struct port *p, struc

Re: [Linuxptp-devel] [PATCH] G.8275.2 support for delay_mechanism NO_MECHANISM

2022-07-25 Thread Richard Cochran
On Mon, Jul 25, 2022 at 02:09:15PM +0530, Devasish Dey wrote: > > Can you please explain what this extra test accomplishes? > > > [Devasish]: This is to enable ts_proc to use t1 and t2 for > tsproc_update_offset. As of now if the initial delay is zero it returns an > error. Got it. Thanks, Richa

Re: [Linuxptp-devel] [PATCH v3] phc2sys: Add support for free-running mode

2022-07-25 Thread Maciek Machnikowski
On Sun, Jul 24, 2022 at 05:46:56PM -0700, Richard Cochran wrote: > On Tue, Jun 21, 2022 at 12:16:40PM +0200, Maciek Machnikowski wrote: > > > @@ -544,6 +546,9 @@ static void update_clock(struct phc2sys_private *priv, > > struct clock *clock, > > > > offset += get_sync_offset(priv, clock); >

[Linuxptp-devel] [PATCH v4] phc2sys: Add support for free-running mode

2022-07-25 Thread Maciek Machnikowski
Add support for the free-running mode that will not adjust the sink clock when enabled. V2: changed implementation to instantiate NTPSHM servo that serves as the nochange servo V3: revert to original implementation and remove unused global V4: fix uninitialized ppb variable in update_clock()

Re: [Linuxptp-devel] [PATCH] G.8275.2 support for delay_mechanism NO_MECHANISM

2022-07-25 Thread Devasish Dey
Hi Richard, Please find the answers inline to your questions. On Mon, 25 Jul 2022 at 02:22, Richard Cochran wrote: > On Fri, Jun 03, 2022 at 05:00:24PM +0530, SyncMonk Technologies wrote: > > > @@ -1996,8 +1996,10 @@ static void handle_state_decision_event(struct > clock *c) > > i

[Linuxptp-devel] [PATCH] G.8275.2 support for delay_mechanism NO_MECHANISM

2022-07-25 Thread SyncMonk Technologies
As per IEEE1588-2019, Table 21 adding NO_MECHANISM support. In this case port does not implement the delay mechanism. Signed-off-by: Greg Armstrong Signed-off-by: Leon Goldin Signed-off-by: Devasish Dey Signed-off-by: Vipin Sharma --- clock.c | 4 +++- config.c | 1 + dm.h

Re: [Linuxptp-devel] [PATCH] unicast: Update announce timer when renew

2022-07-25 Thread Miroslav Lichvar
On Sun, Jul 24, 2022 at 03:49:41PM -0700, Richard Cochran wrote: > On Tue, Jun 14, 2022 at 06:17:51AM -0700, Vadim Fedorenko via Linuxptp-devel > wrote: > > @@ -467,6 +467,7 @@ void unicast_client_grant(struct port *p, struct > > ptp_message *m, > > ucma->granted |= 1 << mtype; > > > >

[Linuxptp-devel] [PATCH v2] port: Disable PHC switch with vclocks.

2022-07-25 Thread Miroslav Lichvar
With a virtual PHC, don't try to switch to the physical PHC after a link-state change. JBOD and other multi-PHC configurations are not supported with vclocks yet. Fixes: 9b9c2c58e6ed ("port: Check for virtual clocks.") Signed-off-by: Miroslav Lichvar --- Notes: v2: Rebased on latest code