Re: [Linuxptp-devel] [PATCH v2 0/4] Bug fix and improved clockcheck

2022-10-20 Thread Keller, Jacob E
> -Original Message- > From: Miroslav Lichvar > Sent: Thursday, October 20, 2022 7:13 AM > To: linuxptp-devel@lists.sourceforge.net > Subject: [Linuxptp-devel] [PATCH v2 0/4] Bug fix and improved clockcheck > > v2: > - added patch to exit on errors returned by read-only clock_adjtime()

Re: [Linuxptp-devel] [PATCH v2 4/4] Extend clockcheck to check for changes in frequency.

2022-10-20 Thread Keller, Jacob E
> -Original Message- > From: Miroslav Lichvar > Sent: Thursday, October 20, 2022 7:13 AM > To: linuxptp-devel@lists.sourceforge.net > Subject: [Linuxptp-devel] [PATCH v2 4/4] Extend clockcheck to check for > changes > in frequency. > > Before setting the new frequency offset on a cloc

Re: [Linuxptp-devel] [PATCH] ptp4l: Add profile_id configuration support for G.8275.1 and G.8275.2.

2022-10-20 Thread Izunna Otiji
Hi Richard, Yes, the new method to get the configuration instance is unnecessary, thanks for the review and comments. Regards, Izunna -Original Message- From: Richard Cochran Sent: Saturday, October 15, 2022 1:17 AM To: Izunna Otiji Cc: linuxptp-devel@lists.sourceforge.net Subject:

Re: [Linuxptp-devel] Introducing SyncESMC (ESMC client) from SyncMonk

2022-10-20 Thread Richard Cochran
On Thu, Oct 20, 2022 at 11:07:55AM +0530, Devasish Dey wrote: > SyncMonk is excited to introduce *SyncESMC*, an implementation for Ethernet > Synchronous Message Channel based on ITU-T G.8264 (03/2018) and ITU-T > G.781(04/2020) standards as a precision timing solution. I looked around for your r

[Linuxptp-devel] [PATCH v2 3/4] Don't accept errors in clockadj_get_freq().

2022-10-20 Thread Miroslav Lichvar
Exit if an error is returned from the clock_adjtime() call in clockadj_get_freq(). No recoverable errors are expected. Signed-off-by: Miroslav Lichvar --- clockadj.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/clockadj.c b/clockadj.c index 957dc57..4c920b9 100644 --- a/clockadj.c +++ b

[Linuxptp-devel] [PATCH v2 0/4] Bug fix and improved clockcheck

2022-10-20 Thread Miroslav Lichvar
v2: - added patch to exit on errors returned by read-only clock_adjtime() - simplified last patch to reuse the set frequency and allow +/-1 ppb error due to conversions between int, double and scaled ppm - improved commit messages This set improves the clock check to consider the last frequency

[Linuxptp-devel] [PATCH v2 1/4] phc2sys: Add clocks after processing configuration.

2022-10-20 Thread Miroslav Lichvar
Clocks specified by the -c option, or the default CLOCK_REALTIME, were added before the default or specified values (e.g. sanity_freq_limit) were set in the private structure used by clock_add(), causing the clocks to work with unexpected values. Rework the code to save the names of sink clocks fr

[Linuxptp-devel] [PATCH v2 4/4] Extend clockcheck to check for changes in frequency.

2022-10-20 Thread Miroslav Lichvar
Before setting the new frequency offset on a clock update, compare the current frequency returned by the kernel with the value saved from the previous update. Print a warning message if the difference is larger than 1 ppb, allowing for rounding errors in conversion to and from double. The kernel ca

[Linuxptp-devel] [PATCH v2 2/4] Drop support for old kernels returning zero frequency.

2022-10-20 Thread Miroslav Lichvar
Kernels before 3.10 had a bug in reading of the system clock frequency, which was worked around by commit da347d7a36f2 ("ptp4l: Set clock frequency on start"). Drop this workaround and support for the old kernels to make clockadj_get_freq() useful. Signed-off-by: Miroslav Lichvar --- clock.c

Re: [Linuxptp-devel] Introducing SyncESMC (ESMC client) from SyncMonk

2022-10-20 Thread Richard Cochran
On Thu, Oct 20, 2022 at 11:07:55AM +0530, Devasish Dey wrote: > Few advantages of design: > >- Single-threaded architecture. >- Hardware agnostic >- Dynamic configuration supported with Sync-Yang, Netconf and SyncCLI. >- Monitoring and visibilities. >- Integrated with Enterpri

Re: [Linuxptp-devel] [PATCH v1 0/3] Fix TAI offset in generic pps source

2022-10-20 Thread Maciek Machnikowski
On Wed, Oct 19, 2022 at 05:22:33PM -0700, Jacob Keller wrote: > > > On 10/18/2022 8:08 AM, Maciek Machnikowski wrote: > > Current implementation of generic pps source relies on the UTC-TAI offset > > read > > from system. Some OSes don't set that offset by default and return 0. In > > such > >