[Linuxptp-devel] [PATCH] remove C99 style loop variable declarations

2022-11-16 Thread Jacob Keller
When building the tlv.c file, the following warning may occur when operating in C89 mode: $make EXTRA_CFLAGS=-std=gnu89 tlv.c: In function ‘mgt_post_recv’: tlv.c:374:17: error: ‘for’ loop initial declarations are only allowed in C99 or C11 mode 374 | for (int i = 0; i <

Re: [Linuxptp-devel] [PATCH] servo: stop rounding initial frequency to nearest ppb

2022-11-16 Thread Keller, Jacob E
> -Original Message- > From: Miroslav Lichvar > Sent: Wednesday, November 16, 2022 4:13 AM > To: Keller, Jacob E > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH] servo: stop rounding initial frequency > to > nearest ppb > > On Tue, Nov 15, 2022 at 04

Re: [Linuxptp-devel] [PATCH] servo: stop rounding initial frequency to nearest ppb

2022-11-16 Thread Miroslav Lichvar
On Tue, Nov 15, 2022 at 04:41:09PM -0800, Jacob Keller wrote: > Refactor the servo_create API to take a double value instead of an integer > value. Fix the clockadj_get_freq and clockadj_set_freq initialization to > avoid casting to an integer and thus rounding the value. Looks good to me. Thanks