[Linuxptp-devel] [PATCH 1/1] msg: append TLV onto all PTP event messages

2023-02-28 Thread Tan Tee Min
According to IEEE Std 1588-2019 Chapter 6.4 PTP message classes, all PTP messages can be extended by means of a standard Type, Length, Value (TLV) extension mechanism. Signed-off-by: Tan Tee Min --- msg.c | 6 +++--- msg.h | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [Linuxptp-devel] [PATCH 1/1] port: add ptpTimescale to the flag field for 802.1AS-2011

2023-02-28 Thread Tan Tee Min
On Fri, Feb 24, 2023 at 07:37:35AM -0800, Richard Cochran wrote: > On Fri, Feb 24, 2023 at 02:25:03PM +, Woojung.Huh--- via Linuxptp-devel > wrote: > > > Agree that 802.1AS-2011 and 802.1AS-2021-Cor1 are marked as All for > > ptpTimescale. > > However, this is updated (fixed) in

Re: [Linuxptp-devel] [PATCH] Set controlField to zero in message headers

2023-02-28 Thread Richard Cochran
On Tue, Feb 28, 2023 at 07:38:44PM +0100, Andrew Zaborowski wrote: > Hi Richard and Erez, > > On Tue, 28 Feb 2023 at 16:02, Richard Cochran > wrote: > > On Tue, Feb 28, 2023 at 09:36:07AM +0100, Erez wrote: > > > May break when using non Linuxptp, as far as I understand, linuxptp only > > >

Re: [Linuxptp-devel] [PATCH] Set controlField to zero in message headers

2023-02-28 Thread Andrew Zaborowski
Hi Richard and Erez, On Tue, 28 Feb 2023 at 16:02, Richard Cochran wrote: > On Tue, Feb 28, 2023 at 09:36:07AM +0100, Erez wrote: > > May break when using non Linuxptp, as far as I understand, linuxptp only > > sets the field, but never checks the value. > > The risk is that some hardware

Re: [Linuxptp-devel] [PATCH v6 00/10] Dynamic sync direction for ts2phc

2023-02-28 Thread Richard Cochran
On Tue, Feb 28, 2023 at 12:03:15PM +0100, Maciek Machnikowski wrote: > Can we add it to the configs/ts2phc*.cfg for the 4.0 release? That is not a critical bug, IMO. Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net

Re: [Linuxptp-devel] [PATCH] Set controlField to zero in message headers

2023-02-28 Thread Richard Cochran
On Tue, Feb 28, 2023 at 09:36:07AM +0100, Erez wrote: > On Tue, 28 Feb 2023 at 01:49, Andrew Zaborowski > > Since the default behaviour changes, in principle this could break > > > > May break when using non Linuxptp, as far as I understand, linuxptp only > sets the field, but never checks the

Re: [Linuxptp-devel] [PATCH v6 00/10] Dynamic sync direction for ts2phc

2023-02-28 Thread Maciek Machnikowski
On 31/08/2022 01:12, Vladimir Oltean wrote > In text, it would be described as this: > > cat ts2phc.cfg > [global] > first_step_threshold0.2 > step_threshold 0.2 > ts2phc.pulsewidth 5 > ts2phc.perout_phase 0 > > #

Re: [Linuxptp-devel] [PATCH] Set controlField to zero in message headers

2023-02-28 Thread Erez
On Tue, 28 Feb 2023 at 01:49, Andrew Zaborowski wrote: > From: Christopher S M Hall > > IEEE1588-2019 and 802.1AS-2020 both require the field to be 0 in > transmitted messages except when the "version 1 hardware option" is set > (IEEE1588-2019 C.4.2) and only with IPv4. Since ptp4l isn't