Re: [Linuxptp-devel] [PATCH v3 0/6] Use precise frequency for TX SYNC messages

2023-04-26 Thread Miroslav Lichvar
On Wed, Apr 26, 2023 at 02:25:12PM +0200, Luigi 'Comio' Mantellini wrote: > Having servers on different > nodes will give a drift because there is not any shared clock in this case. If the nodes had their system clocks synchronized, as would normally be expected, the sync transmissions would not

[Linuxptp-devel] [PATCH] Clear pending errors on sockets.

2023-04-26 Thread Miroslav Lichvar
When the netlink socket of a port (used for receiving link up/down events) had an error (e.g. ENOBUFS due to the kernel sending too many messages), ptp4l switched the port to the faulty state, but it kept getting POLLERR on the socket and logged "port 1: unexpected socket error" in an infinite

Re: [Linuxptp-devel] [PATCH v3 0/6] Use precise frequency for TX SYNC messages

2023-04-26 Thread Luigi 'Comio' Mantellini
Hi Miroslav, find my inline answers. Il giorno mer 26 apr 2023 alle ore 11:15 Miroslav Lichvar < mlich...@redhat.com> ha scritto: > On Wed, Apr 26, 2023 at 10:43:52AM +0200, Luigi 'Comio' Mantellini wrote: > > Hi Miroslav, > > > > Sync is already sent using a constant interval as required by

Re: [Linuxptp-devel] [PATCH v5 1/2] pmc_agent: Add option to run callback for signaling messages

2023-04-26 Thread Erez
On Wed, 26 Apr 2023 at 11:55, Maciek Machnikowski wrote: > On 4/21/2023 6:46 PM, Erez wrote: > > > > > > On Fri, 21 Apr 2023 at 17:27, Maciek Machnikowski > > mailto:mac...@machnikowski.net>> wrote: > > > > On 4/21/2023 1:25 PM, Erez wrote: > > > > > > > > > On Thu, 20 Apr 2023

[Linuxptp-devel] [PATCH v6 2/2] ts2phc: Add PTP as a source of ToD

2023-04-26 Thread Maciek Machnikowski
Add PPS ToD source that extracts ToD from master timestamps from a slave event monitor of the running ptp4l instance. It enables scenarios where reliable ToD sources, such as nmea, may not be available, but a system is connected to different ptp masters. It can be used in the APTS deployment

[Linuxptp-devel] [PATCH v6 1/2] pmc_agent: Add option to run callback for signaling messages

2023-04-26 Thread Maciek Machnikowski
Add option to run callback that when the PMC agent receives signaling messages. v2: changed pmc_agent implementation to not use a separate callback v3: updated poll thread to use less CPU v4: changed sleep routine to usleep, simplified poll thread v5: make sure management_tlv_id is not called on

Re: [Linuxptp-devel] [PATCH v5 1/2] pmc_agent: Add option to run callback for signaling messages

2023-04-26 Thread Maciek Machnikowski
On 4/21/2023 6:46 PM, Erez wrote: > > > On Fri, 21 Apr 2023 at 17:27, Maciek Machnikowski > mailto:mac...@machnikowski.net>> wrote: > > On 4/21/2023 1:25 PM, Erez wrote: > > > > > > On Thu, 20 Apr 2023 at 19:01, Maciek Machnikowski > > mailto:mac...@machnikowski.net> >

Re: [Linuxptp-devel] [PATCH v3 0/6] Use precise frequency for TX SYNC messages

2023-04-26 Thread Miroslav Lichvar
On Wed, Apr 26, 2023 at 10:43:52AM +0200, Luigi 'Comio' Mantellini wrote: > Hi Miroslav, > > Sync is already sent using a constant interval as required by Standard even > if it is lower than the nominal frequency for the actual implementation > (stop and rearm). It's not constant. It's

Re: [Linuxptp-devel] [PATCH v3 0/6] Use precise frequency for TX SYNC messages

2023-04-26 Thread Luigi 'Comio' Mantellini
Hi Miroslav, Sync is already sent using a constant interval as required by Standard even if it is lower than the nominal frequency for the actual implementation (stop and rearm). In other hands, you already have the depicted problems on your HW, if any, but on a different resonance frequency. The

Re: [Linuxptp-devel] [PATCH v3 0/6] Use precise frequency for TX SYNC messages

2023-04-26 Thread Miroslav Lichvar
On Thu, Mar 30, 2023 at 08:08:12AM +0200, Luigi Mantellini wrote: > The actual ptp4l implementation rearms timers after the expiration. This > approach doesn't permit to have a precise TX SYNC message scheduling. > During my test the TX SYNC frequency is slightly lower the expectation (eg >

Re: [Linuxptp-devel] [PATCH v2 0/1] Last (?) patch before version 4 release

2023-04-26 Thread Maciek Machnikowski
On 4/19/2023 11:43 AM, Maciek Machnikowski wrote: > On 4/17/2023 4:34 PM, Richard Cochran wrote: >> On Mon, Apr 17, 2023 at 11:07:10AM +0200, Miroslav Lichvar wrote: >> >>> As for the 4.0 release, can you please have a look at this bug fix? >>>

Re: [Linuxptp-devel] [PATCH v3 0/6] Use precise frequency for TX SYNC messages

2023-04-26 Thread Luigi 'Comio' Mantellini
Announce messages are randomized using the set_tmo_random() call. ciao luigi Il giorno mer 26 apr 2023 alle ore 04:57 Richard Cochran < richardcoch...@gmail.com> ha scritto: > On Tue, Apr 25, 2023 at 06:23:53PM +0200, Luigi 'Comio' Mantellini wrote: > > Any review on this patchset? > > I'm