[Linuxptp-devel] [PATCH v1] lstab: Update leapfile validity

2023-04-30 Thread Harlan Stenn
On 4/29/2023 4:45 PM, Richard Cochran wrote: On Thu, Apr 27, 2023 at 09:58:13AM +0200, Maciek Machnikowski wrote: No leap seconds will happen till the end of 2023. (Only twelve more years of this BS to endure. ;^) A close link between UT0 and UT1 is considered to to be a feature by some.

Re: [Linuxptp-devel] [PATCH] Clear pending errors on sockets.

2023-04-30 Thread Richard Cochran
On Wed, Apr 26, 2023 at 02:44:27PM +0200, Miroslav Lichvar wrote: > When the netlink socket of a port (used for receiving link up/down > events) had an error (e.g. ENOBUFS due to the kernel sending too many > messages), ptp4l switched the port to the faulty state, but it kept > getting POLLERR on

Re: [Linuxptp-devel] Bug caused by commit afeabf3 "ptp4l: add VLAN over bond support" on kernel 4.9

2023-04-30 Thread Richard Cochran
On Thu, Mar 30, 2023 at 11:16:44AM +0800, Hangbin Liu wrote: > Richard, what do you think? This code in hwts_init is wrong: cfg.flags = HWTSTAMP_FLAG_BONDED_PHC_INDEX; /* Fall back without flag if user run new build on old kernel */ if (ioctl(fd, SIOCGHWTSTAMP, ) ==

Re: [Linuxptp-devel] [PATCH] Fix power profile config option range to UINT32_MAX

2023-04-30 Thread Richard Cochran
On Mon, Apr 24, 2023 at 12:21:57PM -0700, Jacob Keller wrote: > The power profile configuration options added in commit 7059a05a3fb2 > ("Introduce the power profile.") specify their maximum range as INT_MAX. > The values are stored as UInteger32 values and the default value is > 0x. On

Re: [Linuxptp-devel] bugs when reading ptp4l configuration files

2023-04-30 Thread Richard Cochran
On Wed, Mar 29, 2023 at 11:30:49AM -0700, Jacob Keller wrote: > This appears to be caused by using a base of 0 to strtol which then > interprets leading 0 numbers as octal. This is probably done in order to > get handling of '0x' prefixed numbers as well, but the leading 0 -> > octal

Re: [Linuxptp-devel] [PATCH] Use lock file to check if uds_address in use

2023-04-30 Thread Richard Cochran
On Tue, Feb 28, 2023 at 01:47:03AM +0100, Andrew Zaborowski wrote: > Use a lock file to be able to log an error when the UDS socket's path is > in use by another instance, avoid silently unlink()ing it. > > There's no way for multiple instances (e.g. in a multi-domain setup) to > bind() to the

Re: [Linuxptp-devel] [PATCH v2] ntpshm: Invalidate SHM data before releasing the servo

2023-04-30 Thread Richard Cochran
On Thu, Mar 16, 2023 at 03:47:47PM +0100, Maciek Machnikowski wrote: > The SHM is not cleared upon servo release when exiting the tool. This > leaves the last update in the shared memory region marked as valid. > > Users may not expect such behavior. If the configuration changed, or the > tool

Re: [Linuxptp-devel] [PATCH 1/1] msg: append TLV onto all PTP event messages

2023-04-30 Thread Richard Cochran
On Wed, Mar 01, 2023 at 01:04:34PM +0800, Tan Tee Min wrote: > According to IEEE Std 1588-2019 Chapter 6.4 PTP message classes, > all PTP messages can be extended by means of a standard > Type, Length, Value (TLV) extension mechanism. Since the present code does not append any TLVs on such