Re: [Linuxptp-devel] [PATCH 0/2 v4] sk: don't report random errno on timeout

2023-07-21 Thread Jacob Keller
On 7/21/2023 2:10 AM, Lukasz Plachno wrote: > Improve error reporting in case of timeout while reading tx timestamp, > extend documentation with information about increasing kthread priority. > > v4: > - added generic example for setting priority for PTP kworkers > - simplified both example c

Re: [Linuxptp-devel] [PATCH v1 1/4] phc2sys: Rename phc2sys_private to domain.

2023-07-21 Thread Jacob Keller
On 7/20/2023 7:33 AM, Miroslav Lichvar wrote: > Rename the phc2sys_private structure to domain in preparation for > support of multiple domains. > > While touching the lines of code, also rename master to source clock. > > Signed-off-by: Miroslav Lichvar Reviewed-by: Jacob Keller

Re: [Linuxptp-devel] [PATCH v1 2/4] phc2sys: Create pmc agent after processing options.

2023-07-21 Thread Jacob Keller
On 7/20/2023 7:33 AM, Miroslav Lichvar wrote: > Keep configuration settings in a separate domain and copy them to the > actual domain just before creating the pmc agent. This will be needed to > share the settings between multiple domains. > > Signed-off-by: Miroslav Lichvar > --- Reviewed-b

Re: [Linuxptp-devel] [PATCH v1 3/4] phc2sys: Shallow do_loop().

2023-07-21 Thread Jacob Keller
On 7/20/2023 7:33 AM, Miroslav Lichvar wrote: > Move the measurements and updates of clocks from do_loop() to separate > function. > > Signed-off-by: Miroslav Lichvar > --- Reviewed-by: Jacob Keller ___ Linuxptp-devel mailing list Linuxptp-devel

Re: [Linuxptp-devel] [PATCH v1] servo: Implement offset statistics

2023-07-21 Thread Maciek Machnikowski
On 7/10/2023 12:33 PM, Maciek Machnikowski wrote: > > > On 7/10/2023 12:03 PM, Miroslav Lichvar wrote: >> On Mon, Jul 10, 2023 at 11:18:36AM +0200, Maciek Machnikowski wrote: >>> Do you mean the one in clock.c? If so, the clock_stats_display resets >>> them, so there's no way of printing the stat

[Linuxptp-devel] [PATCH 2/2] ptp4l: Add description for setting kthreads priorities

2023-07-21 Thread Lukasz Plachno
As tx timestamp timeout is something multiple users encounter, provide information for configuring kthread priorities in manual for ptp4l where tx_timestamp_timeout is already described. Signed-off-by: Lukasz Plachno --- ptp4l.8 | 32 1 file changed, 32 insertion

[Linuxptp-devel] [PATCH 0/2 v4] sk: don't report random errno on timeout

2023-07-21 Thread Lukasz Plachno
Improve error reporting in case of timeout while reading tx timestamp, extend documentation with information about increasing kthread priority. v4: - added generic example for setting priority for PTP kworkers - simplified both example commands (generic and ICE) for setting priority v3: - v2

[Linuxptp-devel] [PATCH 1/2] sk: don't report random errno on timeout

2023-07-21 Thread Lukasz Plachno
From: Przemek Kitszel With neither caller nor poll() itself zeroing errno value, it will contain result of previous failure, possibly from long time ago. Reporting errno=0 up from sk_receive() would bring confusion, as "%m" is later used in pr_err() (so one would get "error Success"). Use ETIME

Re: [Linuxptp-devel] [PATCH 2/2] ptp4l: Add description for setting kthreads priorities

2023-07-21 Thread Plachno, Lukasz
On 7/21/2023 10:52 AM, Lukasz Plachno wrote: As tx timestamp timeout is something multiple users encounter, provide information for configuring kthread priorities in manual for ptp4l where tx_timestamp_timeout is already described. Signed-off-by: Lukasz Plachno --- ptp4l.8 | 20 ++

[Linuxptp-devel] [PATCH 1/2] sk: don't report random errno on timeout

2023-07-21 Thread Lukasz Plachno
From: Przemek Kitszel With neither caller nor poll() itself zeroing errno value, it will contain result of previous failure, possibly from long time ago. Reporting errno=0 up from sk_receive() would bring confusion, as "%m" is later used in pr_err() (so one would get "error Success"). Use ETIME

[Linuxptp-devel] [v3 PATCH 0/2] sk: don't report random errno on timeout

2023-07-21 Thread Lukasz Plachno
Improve error reporting in case of timeout while reading tx timestamp, extend documentation with information about increasing kthread priority. v3: - added generic example for setting priority for PTP kworkers - simplified both example commands (generic and ICE) for setting priority v2: - added

[Linuxptp-devel] [PATCH 2/2] ptp4l: Add description for setting kthreads priorities

2023-07-21 Thread Lukasz Plachno
As tx timestamp timeout is something multiple users encounter, provide information for configuring kthread priorities in manual for ptp4l where tx_timestamp_timeout is already described. Signed-off-by: Lukasz Plachno --- ptp4l.8 | 20 1 file changed, 20 insertions(+) diff -

Re: [Linuxptp-devel] [PATCH 2/2] ptp4l: Add description for setting kthreads priorities

2023-07-21 Thread Plachno, Lukasz
On 7/19/2023 8:16 PM, Keller, Jacob E wrote: -Original Message- From: Plachno, Lukasz Sent: Wednesday, July 19, 2023 9:48 AM To: linuxptp-devel@lists.sourceforge.net Cc: Kitszel, Przemyslaw ; richardcoch...@gmail.com; mac...@machnikowski.net; Keller, Jacob E ; Plachno, Lukasz Subject