Re: [Linuxptp-devel] [PATCH 2/2] linuxptp: Use ${CC} in incdefs.sh

2023-10-20 Thread Richard Cochran
On Fri, Oct 20, 2023 at 12:59:57PM -0700, Richard Cochran wrote: > On Fri, Oct 20, 2023 at 07:15:59PM +0200, Erez wrote: > > > And we can change CC to > > CC ?= ... > > > > In case CC comes from the build, like in Yocto and Debian. > > Nah, build systems that don't want to use gcc can and should

Re: [Linuxptp-devel] [PATCH 1/2] include string.h for strncpy()

2023-10-20 Thread Richard Cochran
On Fri, Oct 20, 2023 at 01:24:51PM -0700, Khem Raj wrote: > Newer compilers complain about missing signatures for stncpy as said in > subject. Well, the why not state which compiler was used, and also share the warning output? Thanks, Richard ___ Lin

Re: [Linuxptp-devel] [PATCH 1/2] include string.h for strncpy()

2023-10-20 Thread Rahul Rameshbabu via Linuxptp-devel
On Fri, 20 Oct, 2023 12:47:39 -0700 Richard Cochran wrote: > On Thu, Oct 19, 2023 at 03:50:20PM +0100, Luca Fancellu wrote: >> From: Khem Raj >> >> Signed-off-by: Khem Raj >> --- >> interface.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/interface.c b/interface.c >> index 292

Re: [Linuxptp-devel] [PATCH 2/2] linuxptp: Use ${CC} in incdefs.sh

2023-10-20 Thread Luca Fancellu
> On 20 Oct 2023, at 16:57, Erez wrote: > > Hi, > > Your statement is correct, but not the implementation. > You need to export CC from the makefile, to get > CC = $(CROSS_COMPILE)gcc > Value. > In your patch CC may have a different value. > > I would use: > " > CC := $(CROSS_COMPILE)gcc > expor

Re: [Linuxptp-devel] [PATCH 2/2] linuxptp: Use ${CC} in incdefs.sh

2023-10-20 Thread Richard Cochran
On Fri, Oct 20, 2023 at 07:15:59PM +0200, Erez wrote: > And we can change CC to > CC ?= ... > > In case CC comes from the build, like in Yocto and Debian. Nah, build systems that don't want to use gcc can and should dial what they want on the command line: make CC=abcxyz See: https://ww

Re: [Linuxptp-devel] [PATCH 2/2] linuxptp: Use ${CC} in incdefs.sh

2023-10-20 Thread Richard Cochran
On Fri, Oct 20, 2023 at 07:15:59PM +0200, Erez wrote: > How about > $(shell CC=${CC} ./incdefs.sh) but using makefile $(CC) and not shell script ${CC} Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists

Re: [Linuxptp-devel] [PATCH 1/2] include string.h for strncpy()

2023-10-20 Thread Richard Cochran
On Thu, Oct 19, 2023 at 03:50:20PM +0100, Luca Fancellu wrote: > From: Khem Raj > > Signed-off-by: Khem Raj > --- > interface.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/interface.c b/interface.c > index 29229ad6f53d..9a83c36933e7 100644 > --- a/interface.c > +++ b/interface.c >

Re: [Linuxptp-devel] [PATCH 2/2] linuxptp: Use ${CC} in incdefs.sh

2023-10-20 Thread Erez
On Fri, 20 Oct 2023 at 18:35, Luca Fancellu wrote: > > > > On 20 Oct 2023, at 16:57, Erez wrote: > > > > Hi, > > > > Your statement is correct, but not the implementation. > > You need to export CC from the makefile, to get > > CC = $(CROSS_COMPILE)gcc > > Value. > > In your patch CC may have a

Re: [Linuxptp-devel] [PATCH 2/2] linuxptp: Use ${CC} in incdefs.sh

2023-10-20 Thread Erez
Hi, Your statement is correct, but not the implementation. You need to export CC from the makefile, to get CC = $(CROSS_COMPILE)gcc Value. In your patch CC may have a different value. I would use: " CC *:*= $(CROSS_COMPILE)gcc export CC " Yes assign with ":=", see https://www.gnu.org/software/ma