[Linuxptp-devel] [PATCH v4 1/2] msg: Enable changing PTP message header version

2023-11-10 Thread Maciek Machnikowski
Some hardware can't properly timestamp packets with the new PTP header version 2.1. This patch introduces a global var ptp_hdr_ver that can be changed externally to allow legacy PTP version to be advertised. Forcing 2.1 also breaks interoperability with some older grandmasters which will ignore pa

[Linuxptp-devel] [PATCH v4 2/2] ptp4l: Allow advertisement of legacy PTP 2.0 protocol

2023-11-10 Thread Maciek Machnikowski
Some hardware can't properly timestamp packets with the new PTP header version 2.1. This patch adds legacy_ptp_ver config option that allows advertising of the legacy 2.0 protocol. Additionally, forcing PTP minor version to be nonzero causes interoperability issues with some legacy grandmasters.

Re: [Linuxptp-devel] [PATCH v2 1/2] Some hardware can't properly timestamp packets with the new PTP header version 2.1. This patch introduces a global var ptp_hdr_ver that can be changed externally to

2023-11-10 Thread Richard Cochran
On Fri, Nov 10, 2023 at 02:03:24PM +0100, Maciek Machnikowski wrote: > Forcing 2.1 also breaks interoperability with some older > grandmasters which will ignore packets with ptp_minor version set. Please limit the subject line to one sentence. Please avoid the phrase, "this patch". >From linux/Do

Re: [Linuxptp-devel] [PATCH v2 2/2] Some hardware can't properly timestamp packets with the new PTP header version 2.1. This patch adds legacy_ptp_ver config option that allows advertising of the lega

2023-11-10 Thread Richard Cochran
On Fri, Nov 10, 2023 at 02:03:25PM +0100, Maciek Machnikowski wrote: > @@ -279,6 +279,7 @@ struct config_item config_tab[] = { > PORT_ITEM_INT("interface_rate_tlv", 0, 0, 1), > GLOB_ITEM_INT("kernel_leap", 1, 0, 1), > GLOB_ITEM_STR("leapfile", NULL), > + GLOB_ITEM_INT("legacy

Re: [Linuxptp-devel] [PATCH v2 2/2] Some hardware can't properly timestamp packets with the new PTP header version 2.1. This patch adds legacy_ptp_ver config option that allows advertising of the lega

2023-11-10 Thread Maciek Machnikowski
On 11/10/2023 5:43 PM, Erez wrote: > > > On Fri, 10 Nov 2023 at 14:05, Maciek Machnikowski > mailto:mac...@machnikowski.net>> wrote: > > Additionally, forcing PTP minor version to be nonzero causes > interoperability issues with some legacy grandmasters. > > Signed-off-by: Maciek

Re: [Linuxptp-devel] [RFC PATCH 0/1] Support for Port level Perforamnce Monitoring Counters

2023-11-10 Thread Richard Cochran
On Fri, Nov 10, 2023 at 07:58:14AM +0100, Luigi 'Comio' Mantellini wrote: > Using just polling on UDS is a bad idea IMHO because you need to capture at > the exact same time point all counters of all ports spending a lot of > effort and cpu. So make it into a PUSH message. > It's better to have

Re: [Linuxptp-devel] [PATCH v1] phc_ctl: Implement setting frequency from system time.

2023-11-10 Thread Richard Cochran
On Fri, Nov 10, 2023 at 11:16:38AM +0100, Maciek Machnikowski wrote: > In my tests it worked fine, but I'd be more than happy to increase it - > would 5s be sufficient there? It should be more like 25 seconds, but you may have very loose requirements. In any case: - The interval must be configu

Re: [Linuxptp-devel] [PATCH v2 2/2] Some hardware can't properly timestamp packets with the new PTP header version 2.1. This patch adds legacy_ptp_ver config option that allows advertising of the lega

2023-11-10 Thread Erez
On Fri, 10 Nov 2023 at 14:05, Maciek Machnikowski wrote: > Additionally, forcing PTP minor version to be nonzero causes > interoperability issues with some legacy grandmasters. > > Signed-off-by: Maciek Machnikowski > --- > config.c| 1 + > configs/default.cfg | 1 + > ptp4l.8

Re: [Linuxptp-devel] [PATCH 5/5] phc2sys: Stop synchronization when ptp4l stops responding.

2023-11-10 Thread Erez
On Fri, 10 Nov 2023 at 07:55, Richard Cochran wrote: > On Thu, Oct 26, 2023 at 02:40:11PM +0200, Miroslav Lichvar wrote: > > > @@ -942,8 +957,8 @@ static int auto_init_ports(struct domain *domain) > > } > > > > err = pmc_agent_subscribe(domain->agent, 1000, > > -

Re: [Linuxptp-devel] [PATCH v3 1/2] msg: Enable changing PTP message header version

2023-11-10 Thread Luigi Mantellini via Linuxptp-devel
N¬ŠÆ¦º[b¥ªí™ë,j¢œÂ ú+™«g{Oj»u÷m7ëË]Y_R ¡ ‰íz{Sʗ¦º[b¥ªíþ·¥jםn‹§uªò signature.asc Description: This is a digitally signed message part. ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo

Re: [Linuxptp-devel] [PATCH v3 1/2] msg: Enable changing PTP message header version

2023-11-10 Thread Luigi 'Comio' Mantellini
I understand that standard defines ptp at instance level, but look this https://github.com/YangModels/yang/blob/main/experimental/ieee/1588/ni-ieee1588-ptp.yang and my proposal was to support broken local hw and broken external hw in a dynamic way. ciao luigi Il giorno ven 10 nov 2023 alle o

[Linuxptp-devel] [PATCH v2] phc_ctl: Implement setting frequency from system time.

2023-11-10 Thread Maciek Machnikowski
Implement auto mode for frequency setting. In this mode the tool will measure the frequency difference between PHC and CLOCK_REALTIME and apply the correction to the PHC to match the system clock. v2: rebase and change measure time to 5 seconds Signed-off-by: Maciek Machnikowski --- phc_ctl.8 |

[Linuxptp-devel] [PATCH v7 2/2] ts2phc: Add PTP as a source of ToD

2023-11-10 Thread Maciek Machnikowski
Add PPS ToD source that extracts ToD from master timestamps from a slave event monitor of the running ptp4l instance. It enables scenarios where reliable ToD sources, such as nmea, may not be available, but a system is connected to different ptp masters. It can be used in the APTS deployment wit

[Linuxptp-devel] [PATCH v7 1/2] pmc_agent: Add option to run callback for signaling messages

2023-11-10 Thread Maciek Machnikowski
Add option to run callback that when the PMC agent receives signaling messages. v2: changed pmc_agent implementation to not use a separate callback v3: updated poll thread to use less CPU v4: changed sleep routine to usleep, simplified poll thread v5: make sure management_tlv_id is not called on n

Re: [Linuxptp-devel] [PATCH v3 1/2] msg: Enable changing PTP message header version

2023-11-10 Thread Maciek Machnikowski
On 11/10/2023 2:48 PM, Luigi Mantellini wrote: > I prefer another approach : > > > 1) All should have the same request ptp version (es: delay-resp copy ptp > version from delay-req, management answers copy from queries, ... and so. NAK this would cause trying to respond with 2.1 packets to the

[Linuxptp-devel] [PATCH v3 2/2] ptp4l: Allow advertisement of legacy PTP 2.0 protocol

2023-11-10 Thread Maciek Machnikowski
Some hardware can't properly timestamp packets with the new PTP header version 2.1. This patch adds legacy_ptp_ver config option that allows advertising of the legacy 2.0 protocol. Additionally, forcing PTP minor version to be nonzero causes interoperability issues with some legacy grandmasters.

[Linuxptp-devel] [PATCH v3 1/2] msg: Enable changing PTP message header version

2023-11-10 Thread Maciek Machnikowski
Some hardware can't properly timestamp packets with the new PTP header version 2.1. This patch introduces a global var ptp_hdr_ver that can be changed externally to allow legacy PTP version to be advertised. Forcing 2.1 also breaks interoperability with some older grandmasters which will ignore pa

[Linuxptp-devel] [PATCH v2 2/2] Some hardware can't properly timestamp packets with the new PTP header version 2.1. This patch adds legacy_ptp_ver config option that allows advertising of the legacy 2

2023-11-10 Thread Maciek Machnikowski
Additionally, forcing PTP minor version to be nonzero causes interoperability issues with some legacy grandmasters. Signed-off-by: Maciek Machnikowski --- config.c| 1 + configs/default.cfg | 1 + ptp4l.8 | 5 + ptp4l.c | 4 4 files changed, 11 insert

[Linuxptp-devel] [PATCH v2 1/2] Some hardware can't properly timestamp packets with the new PTP header version 2.1. This patch introduces a global var ptp_hdr_ver that can be changed externally to all

2023-11-10 Thread Maciek Machnikowski
Forcing 2.1 also breaks interoperability with some older grandmasters which will ignore packets with ptp_minor version set. Signed-off-by: Maciek Machnikowski --- msg.c | 1 + msg.h | 5 + port.c | 18 +- 3 files changed, 15 insertions(+), 9 deletions(-) diff --git a/msg

Re: [Linuxptp-devel] [PATCH v1] phc_ctl: Implement setting frequency from system time.

2023-11-10 Thread Maciek Machnikowski
On 11/10/2023 7:02 AM, Richard Cochran wrote: > On Wed, Sep 13, 2023 at 05:09:04PM +, Maciek Machnikowski wrote: >> Implement auto mode for frequency setting. In this mode the tool >> will measure the frequency difference between PHC and CLOCK_REALTIME >> and apply the correction to the PHC