Re: [Linuxptp-devel] [RFC PATCH v2 1/9] Add new TLV for CommonMeanLinkDelayInformation

2023-11-16 Thread Richard Cochran
On Fri, Nov 17, 2023 at 01:41:19AM +0100, Andrew Zaborowski wrote: > On Thu, 16 Nov 2023 at 23:46, Richard Cochran > wrote: > > No, I mean the PTP port number. These are taken from the order of the > > interfaces on the command line and in the configuration file. > > Won't this be the same as

Re: [Linuxptp-devel] [RFC PATCH v2 1/9] Add new TLV for CommonMeanLinkDelayInformation

2023-11-16 Thread Andrew Zaborowski
On Thu, 16 Nov 2023 at 23:46, Richard Cochran wrote: > On Thu, Nov 16, 2023 at 11:11:50PM +0100, Andrew Zaborowski wrote: > > The two timestamps are passed to clock_peer_delay() by the receiving > > port and stored in c->tsproc. Then they're accessed by > > get_raw_delay() which is used in the

Re: [Linuxptp-devel] [RFC PATCH v2 1/9] Add new TLV for CommonMeanLinkDelayInformation

2023-11-16 Thread Richard Cochran
On Thu, Nov 16, 2023 at 11:11:50PM +0100, Andrew Zaborowski wrote: > The two timestamps are passed to clock_peer_delay() by the receiving > port and stored in c->tsproc. Then they're accessed by > get_raw_delay() which is used in the filter logic. I'm not sure how > much value that has, we can

Re: [Linuxptp-devel] [RFC PATCH v2 1/9] Add new TLV for CommonMeanLinkDelayInformation

2023-11-16 Thread Andrew Zaborowski
On Thu, 16 Nov 2023 at 05:27, Richard Cochran wrote: > On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote: > > @@ -1129,6 +1130,27 @@ static int port_management_fill_response(struct port > > *target, > > memcpy(pwr, >pwr, sizeof(*pwr)); > > datalen =

Re: [Linuxptp-devel] [PATCH] Problem: Under GNSS error condition/fluctuation, ts2phc updating 1sec time into PHC resulting in wrong time.

2023-11-16 Thread Richard Cochran
On Thu, Nov 16, 2023 at 10:42:33AM +, ramesh t wrote: > Under GNSS fluctuation condition due bad weather or improper > location of GNSS antenna, observed ts2phc process updates 1 sec > difference into the physical hard clock (PHC) of the NIC. This 1 > sec jump is seen momentarily as captured

Re: [Linuxptp-devel] [PATCH] Problem: Under GNSS error condition/fluctuation, ts2phc updating 1sec time into PHC resulting in wrong time.

2023-11-16 Thread ramesh t via Linuxptp-devel
Thanks Richard for the feedback. Please find update comments with code changes. >From a8e9b8ade110ff9eb9acc2bb28c6e3d1db136c29 Mon Sep 17 00:00:00 2001 From: Ramesh Gowda Date: Thu, 12 Oct 2023 15:26:27 +0530 Subject: [PATCH] GNSS fluctuation resulting in wrong update of NIC PHC time. Context: