On 12/1/23 10:07 PM, Richard Cochran wrote:
On Thu, Nov 30, 2023 at 04:52:44PM -0800, Kishen Maloor wrote:
CMLDS ptp4l process would be configured with
transportSpecific/domain=0x2/0.
Question about the spec:
How on earth is this going to work?
I mean, if the link partner is not also using
Hi Richard,
Firstly, thanks so much for your reviews and efforts to get
this done.
I'll just rehash a couple of points also raised by Andrew.
On this change below:
> +static int port_cmlds_initialize(struct port *p)
> +{
> + struct config *cfg = clock_config(p->clock);
> + struct
On 5/16/23 3:56 AM, Erez wrote:
> On Tue, 16 May 2023 at 00:29, Kishen Maloor wrote:
>
>> In a setup with multiple gPTP domains, the Common Mean Link Delay Service
>> (CMLDS) (IEEE 1588/16.6.3) performs link delay measurements in a single
>> domain and must (someho
This adds two example config files to instantate a gPTP domain 0 instance
that hosts a CMLDS Link Port (run_cmlds=1) and a gPTP domain 1 instance
that invokes the CMLDS using the COMMON_P2P delay mechanism.
Signed-off-by: Kishen Maloor
---
configs/gPTP-cmlds.cfg | 34
.
* Documented newly added config file options in ptp4l.8.
Andrew Zaborowski (1):
Implement the COMMON_P2P delay mechanism
Kishen Maloor (8):
Add new TLV for CommonMeanLinkDelayInformation
Add configuration options for CMLDS
Add DM_COMMON_P2P
Update the PdelayReq/Res flows for CMLDS Link
ot; setting. Default behavior applies otherwise.
Co-authored-by: Andrew Zaborowski
Signed-off-by: Kishen Maloor
---
port.c | 68 +++---
1 file changed, 60 insertions(+), 8 deletions(-)
diff --git a/port.c b/port.c
index 87780fd39caa.
-off-by: Kishen Maloor
---
port.c | 67 --
1 file changed, 65 insertions(+), 2 deletions(-)
diff --git a/port.c b/port.c
index 435d9ab543c7..acce160b6499 100644
--- a/port.c
+++ b/port.c
@@ -772,9 +772,62 @@ int port_clr_tmo(int fd
This change adds COMMON_P2P (IEEE 802.1AS-2020, clause 14.8.5) to the
enumeration of delay mechanisms and incorporates it into existing code
paths pertaining to DM_P2P to (where appropriate) maintain parity with
DM_P2P.
Co-authored-by: Andrew Zaborowski
Signed-off-by: Kishen Maloor
to be able to comply with IEEE 802.1AS-2020,
clause 11.5.3 which specifies a default value of 9 (and in the range of
1-255).
Signed-off-by: Kishen Maloor
---
config.c | 1 +
port.c | 6 +++---
port_private.h | 1 +
ptp4l.8| 6 ++
4 files changed, 11 insertions(+), 3
. These values collectively aid other gPTP domains to
complete their delay/offset computations via the COMMON_P2P
delay mechanism.
Updated 'pmc' to support the new MID, MID_CMLDS_INFO_NP.
Co-authored-by: Andrew Zaborowski
Signed-off-by: Kishen Maloor
---
clock.c| 1 -
msg.h | 2
From: Andrew Zaborowski
This change implements the COMMON_P2P DM by issuing a request
to the CMLDS for CommonMeanLinkDelayInformation upon expiry of
the delay timer and handles the response to assimilate the
received meanPathDelay and NRR.
Signed-off-by: Andrew Zaborowski
---
port.c | 35
instance on the PTP node that exposes the
CMLDS. A port which employs the COMMON_P2P delay mechanism would
communicate with the CMLDS over the UDS.
Co-authored-by: Andrew Zaborowski
Signed-off-by: Kishen Maloor
---
config.c | 4
port.c | 28
port.h
by: Andrew Zaborowski
Signed-off-by: Kishen Maloor
---
clock.c| 10
clock.h| 6 +++
port.c | 133 -
port_private.h | 2 +
4 files changed, 149 insertions(+), 2 deletions(-)
diff --git a/clock.c b/clock.c
index c7
On 3/20/23 8:10 PM, Richard Cochran wrote:
> On Mon, Mar 20, 2023 at 02:40:30PM -0700, Kishen Maloor wrote:
>> On 3/20/23 12:31 PM, Richard Cochran wrote:
>>> On Sun, Mar 19, 2023 at 10:36:48PM -0400, Kishen Maloor wrote:
>>>
>>>> 'run_cmlds': This per-
On 3/20/23 12:31 PM, Richard Cochran wrote:
> On Sun, Mar 19, 2023 at 10:36:48PM -0400, Kishen Maloor wrote:
>
>> 'run_cmlds': This per-port setting (0/1) declares that a port
>> will perform the role of a CMLDS Link Port (IEEE 1588, clause 16.6.1)
>> and execute C
ot; setting. Default behavior applies otherwise.
Co-authored-by: Andrew Zaborowski
Signed-off-by: Kishen Maloor
---
port.c | 68 +++---
1 file changed, 60 insertions(+), 8 deletions(-)
diff --git a/port.c b/port.c
index e31e697310c2.
From: Andrew Zaborowski
This change implements the COMMON_P2P DM by issuing a request
to the CMLDS for CommonMeanLinkDelayInformation upon expiry of
the delay timer and handles the response to assimilate the
received meanPathDelay and NRR.
Signed-off-by: Andrew Zaborowski
---
pmc.c |
This change introduces a new TLV to convey link delay
measurements by the Common Mean Link Delay Service (CMLDS)
(as specified in IEEE 1588/16.6.3) over the management
interface. Also updated 'pmc' to support the new MID,
MID_CMLDS_INFO_NP.
Co-authored-by: Andrew Zaborowski
Signed-off-by: Kishen
instance on the PTP node that exposes the
CMLDS. A port which employs the COMMON_P2P delay mechanism would
communicate with the CMLDS over the UDS.
Co-authored-by: Andrew Zaborowski
Signed-off-by: Kishen Maloor
---
config.c | 4
port.c | 28
port.h
-off-by: Kishen Maloor
---
port.c | 67 --
1 file changed, 65 insertions(+), 2 deletions(-)
diff --git a/port.c b/port.c
index e632316aa492..9040453fb2dc 100644
--- a/port.c
+++ b/port.c
@@ -772,9 +772,62 @@ int port_clr_tmo(int fd
.
#TODO:
* Document the new configuration options in ptp4l.8.
Andrew Zaborowski (1):
Implement the COMMON_P2P delay mechanism
Kishen Maloor (7):
Add new TLV for CommonMeanLinkDelayInformation
Add configuration options for CMLDS
Add DM_COMMON_P2P
Update the PdelayReq/Res flows for CMLDS
This change adds COMMON_P2P (IEEE 802.1AS-2020, clause 14.8.5) to the
enumeration of delay mechanisms and incorporates it into existing code
paths pertaining to DM_P2P to (where appropriate) maintain parity with
DM_P2P.
Co-authored-by: Andrew Zaborowski
Signed-off-by: Kishen Maloor
by: Andrew Zaborowski
Signed-off-by: Kishen Maloor
---
clock.c| 10
clock.h| 6 +++
port.c | 131 -
port_private.h | 2 +
4 files changed, 147 insertions(+), 2 deletions(-)
diff --git a/clock.c b/clock.c
index 85
This adds two example config files to instantate a gPTP domain 0 instance
that hosts a CMLDS Link Port (run_cmlds=1) and a gPTP domain 1 instance
that invokes the CMLDS using the COMMON_P2P delay mechanism.
Signed-off-by: Kishen Maloor
---
configs/gPTP-cmlds.cfg | 34
24 matches
Mail list logo
