Re: [Linuxptp-devel] [PATCH] Set controlField to zero in message headers

2023-04-15 Thread Richard Cochran
On Thu, Mar 16, 2023 at 02:58:33PM +0100, Andrew Zaborowski wrote: > I was now made aware that Avnu conformance tests for 802.1AS-2011 do > validate the 3 different values required in the control field in that > version of IEEE802.1AS. While 1588-2008 did already say that the use > of this field

Re: [Linuxptp-devel] [PATCH] Set controlField to zero in message headers

2023-03-16 Thread Andrew Zaborowski
On Tue, 28 Feb 2023 at 22:08, Richard Cochran wrote: > On Tue, Feb 28, 2023 at 07:38:44PM +0100, Andrew Zaborowski wrote: > > On Tue, 28 Feb 2023 at 16:02, Richard Cochran > > wrote: > > > In the case of the PTP minor version field, there are already two > > > known bad HW devices that fail when

Re: [Linuxptp-devel] [PATCH] Set controlField to zero in message headers

2023-02-28 Thread Richard Cochran
On Tue, Feb 28, 2023 at 07:38:44PM +0100, Andrew Zaborowski wrote: > Hi Richard and Erez, > > On Tue, 28 Feb 2023 at 16:02, Richard Cochran > wrote: > > On Tue, Feb 28, 2023 at 09:36:07AM +0100, Erez wrote: > > > May break when using non Linuxptp, as far as I understand, linuxptp only > > > sets

Re: [Linuxptp-devel] [PATCH] Set controlField to zero in message headers

2023-02-28 Thread Andrew Zaborowski
Hi Richard and Erez, On Tue, 28 Feb 2023 at 16:02, Richard Cochran wrote: > On Tue, Feb 28, 2023 at 09:36:07AM +0100, Erez wrote: > > May break when using non Linuxptp, as far as I understand, linuxptp only > > sets the field, but never checks the value. > > The risk is that some hardware impleme

Re: [Linuxptp-devel] [PATCH] Set controlField to zero in message headers

2023-02-28 Thread Richard Cochran
On Tue, Feb 28, 2023 at 09:36:07AM +0100, Erez wrote: > On Tue, 28 Feb 2023 at 01:49, Andrew Zaborowski > > Since the default behaviour changes, in principle this could break > > > > May break when using non Linuxptp, as far as I understand, linuxptp only > sets the field, but never checks the va

Re: [Linuxptp-devel] [PATCH] Set controlField to zero in message headers

2023-02-28 Thread Erez
On Tue, 28 Feb 2023 at 01:49, Andrew Zaborowski wrote: > From: Christopher S M Hall > > IEEE1588-2019 and 802.1AS-2020 both require the field to be 0 in > transmitted messages except when the "version 1 hardware option" is set > (IEEE1588-2019 C.4.2) and only with IPv4. Since ptp4l isn't paddin

[Linuxptp-devel] [PATCH] Set controlField to zero in message headers

2023-02-27 Thread Andrew Zaborowski
From: Christopher S M Hall IEEE1588-2019 and 802.1AS-2020 both require the field to be 0 in transmitted messages except when the "version 1 hardware option" is set (IEEE1588-2019 C.4.2) and only with IPv4. Since ptp4l isn't padding the UDP messages to 124 bytes as required for compatibility with