Re: [Linuxptp-devel] [PATCH 1/1] TLV management messages need to be aligned to 16 bits.

2022-04-30 Thread Richard Cochran
On Tue, Mar 08, 2022 at 10:55:14PM +0100, Erez Geva wrote: > Add reserved octet to the new port hardware clock structure. > > Signed-off-by: Erez Geva Applied. Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net http

Re: [Linuxptp-devel] [PATCH 1/1] TLV management messages need to be aligned to 16 bits.

2022-03-16 Thread Keller, Jacob E
> -Original Message- > From: Dale Smith > Sent: Tuesday, March 15, 2022 5:07 PM > To: Erez Geva > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH 1/1] TLV management messages need to be > aligned to 16 bits. > >

Re: [Linuxptp-devel] [PATCH 1/1] TLV management messages need to be aligned to 16 bits.

2022-03-15 Thread Dale Smith
On 3/8/22, Erez Geva wrote: > struct PortIdentity portIdentity; > Integer32 phc_index; > UInteger8 flags; > + uint8_t reserved; What is the difference between uint8_t and UInteger8 ? Shouldn't these be the same type? I don't know, but it looks fishy to me. -Dale

Re: [Linuxptp-devel] [PATCH 1/1] TLV management messages need to be aligned to 16 bits.

2022-03-15 Thread Erez
On Tue, 15 Mar 2022 at 17:14, Miroslav Lichvar wrote: > On Tue, Mar 08, 2022 at 10:55:14PM +0100, Erez Geva wrote: > > Add reserved octet to the new port hardware clock structure. > > > @@ -354,6 +354,7 @@ struct port_hwclock_np { > > struct PortIdentity portIdentity; > > Integer32 ph

Re: [Linuxptp-devel] [PATCH 1/1] TLV management messages need to be aligned to 16 bits.

2022-03-15 Thread Erez
On Tue, 15 Mar 2022 at 23:38, Erez wrote: > > > On Tue, 15 Mar 2022 at 17:14, Miroslav Lichvar > wrote: > >> On Tue, Mar 08, 2022 at 10:55:14PM +0100, Erez Geva wrote: >> > Add reserved octet to the new port hardware clock structure. >> >> > @@ -354,6 +354,7 @@ struct port_hwclock_np { >> >

Re: [Linuxptp-devel] [PATCH 1/1] TLV management messages need to be aligned to 16 bits.

2022-03-15 Thread Miroslav Lichvar
On Tue, Mar 08, 2022 at 10:55:14PM +0100, Erez Geva wrote: > Add reserved octet to the new port hardware clock structure. > @@ -354,6 +354,7 @@ struct port_hwclock_np { > struct PortIdentity portIdentity; > Integer32 phc_index; > UInteger8 flags; > + uint8_t reserved; > } PA

[Linuxptp-devel] [PATCH 1/1] TLV management messages need to be aligned to 16 bits.

2022-03-08 Thread Erez Geva
Add reserved octet to the new port hardware clock structure. Signed-off-by: Erez Geva --- tlv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tlv.h b/tlv.h index 60a9edb..8966696 100644 --- a/tlv.h +++ b/tlv.h @@ -354,6 +354,7 @@ struct port_hwclock_np { struct PortIdentity portIde