Re: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc

2021-07-18 Thread Richard Cochran
On Fri, May 14, 2021 at 01:33:41PM +0200, Lars Munch wrote: > tm_isdst needs to be initialized to make sure mktime does not fail > on recent versions of glibc > > See: > https://bugzilla.redhat.com/show_bug.cgi?id=1653340 > https://sourceware.org/bugzilla/show_bug.cgi?id=24630 > > Signed-off-by:

Re: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc

2021-05-14 Thread Lars Munch
t; Sent: Friday, 14 May 2021 19:30 > To: Geva, Erez (ext) (DI PA DCP R&D 3) > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable > in nmea_scan_rmc > > So how about the following simple explanation? > >

Re: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc

2021-05-14 Thread Geva, Erez
m: Lars Munch Sent: Friday, 14 May 2021 19:30 To: Geva, Erez (ext) (DI PA DCP R&D 3) Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc So how about the following simple explanation? According to POSIX.1-2017 t

Re: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc

2021-05-14 Thread Lars Munch
> It is also does not helps the Developers to understand, why do we need the > > patch (which we do need). > > > > > > > > We are a source project, not a binary one > > > > > > > > Erez > > > > > > > > -Original Message-

Re: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc

2021-05-14 Thread Geva, Erez
We are a source project, not a binary one > > > > Erez > > > > -Original Message- > From: Lars Munch > Sent: Friday, 14 May 2021 13:34 > To: linuxptp-devel@lists.sourceforge.net > Subject: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in

Re: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc

2021-05-14 Thread Lars Munch
> > > > -Original Message- > From: Lars Munch > Sent: Friday, 14 May 2021 13:34 > To: linuxptp-devel@lists.sourceforge.net > Subject: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in > nmea_scan_rmc > > > > tm_isdst needs to be initi

Re: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc

2021-05-14 Thread Geva, Erez
, not a binary one 😊 Erez -Original Message- From: Lars Munch Sent: Friday, 14 May 2021 13:34 To: linuxptp-devel@lists.sourceforge.net Subject: [Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc tm_isdst needs to be initialized to make sure mktime

[Linuxptp-devel] [PATCH 1/4] ts2phc: Fix uninitialized variable in nmea_scan_rmc

2021-05-14 Thread Lars Munch
tm_isdst needs to be initialized to make sure mktime does not fail on recent versions of glibc See: https://bugzilla.redhat.com/show_bug.cgi?id=1653340 https://sourceware.org/bugzilla/show_bug.cgi?id=24630 Signed-off-by: Lars Munch --- nmea.c | 1 + 1 file changed, 1 insertion(+) diff --git a/