Re: [Linuxptp-devel] [PATCH 2/2] phc_ctl: use PTP_CLOCK_GETCAPS2 ioctl if available

2023-06-22 Thread Jacob Keller
On 12/8/2022 1:20 PM, Geva, Erez wrote: > On Wed, 2022-12-07 at 06:59 -0800, Richard Cochran wrote: >> On Thu, Nov 17, 2022 at 02:15:23PM -0800, Jacob Keller wrote: >>> On 11/17/2022 1:34 PM, Geva, Erez wrote: >> The problem is the fallback works only on build. But if the build system i

Re: [Linuxptp-devel] [PATCH 2/2] phc_ctl: use PTP_CLOCK_GETCAPS2 ioctl if available

2022-12-08 Thread Geva, Erez
On Wed, 2022-12-07 at 06:59 -0800, Richard Cochran wrote: > On Thu, Nov 17, 2022 at 02:15:23PM -0800, Jacob Keller wrote: > > On 11/17/2022 1:34 PM, Geva, Erez wrote: > > > > The problem is the fallback works only on build. > > > But if the build system is newer than the running system, the > > >

Re: [Linuxptp-devel] [PATCH 2/2] phc_ctl: use PTP_CLOCK_GETCAPS2 ioctl if available

2022-12-07 Thread Richard Cochran
On Thu, Nov 17, 2022 at 02:15:23PM -0800, Jacob Keller wrote: > On 11/17/2022 1:34 PM, Geva, Erez wrote: > > The problem is the fallback works only on build. > > But if the build system is newer than the running system, the fallback > > will fail, as you will use the PTP_CLOCK_GETCAPS2 which does

Re: [Linuxptp-devel] [PATCH 2/2] phc_ctl: use PTP_CLOCK_GETCAPS2 ioctl if available

2022-11-17 Thread Jacob Keller
] phc_ctl: use PTP_CLOCK_GETCAPS2 ioctl if available On Tue, 2022-11-15 at 16:43 -0800, Jacob Keller wrote: The PTP_CLOCK_GETCAPS2 ioctl is provided by kernel as a replacement for the original PTP_CLOCK_GETCAPS ioctl. This was done in order to provide ioctls which guarantee reserved fields are properly

Re: [Linuxptp-devel] [PATCH 2/2] phc_ctl: use PTP_CLOCK_GETCAPS2 ioctl if available

2022-11-17 Thread Geva, Erez
On Thu, 2022-11-17 at 18:27 +, Keller, Jacob E wrote: > > > > -Original Message- > > From: Geva, Erez > > Sent: Thursday, November 17, 2022 9:13 AM > > To: Keller, Jacob E ; linuxptp- > > de...@lists.sourceforge.net > > Subject: Re:

Re: [Linuxptp-devel] [PATCH 2/2] phc_ctl: use PTP_CLOCK_GETCAPS2 ioctl if available

2022-11-17 Thread Keller, Jacob E
> -Original Message- > From: Geva, Erez > Sent: Thursday, November 17, 2022 9:13 AM > To: Keller, Jacob E ; linuxptp- > de...@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH 2/2] phc_ctl: use PTP_CLOCK_GETCAPS2 > ioctl if available > > On Tue

Re: [Linuxptp-devel] [PATCH 2/2] phc_ctl: use PTP_CLOCK_GETCAPS2 ioctl if available

2022-11-17 Thread Geva, Erez
On Tue, 2022-11-15 at 16:43 -0800, Jacob Keller wrote: > The PTP_CLOCK_GETCAPS2 ioctl is provided by kernel as a replacement > for the > original PTP_CLOCK_GETCAPS ioctl. This was done in order to provide > ioctls > which guarantee reserved fields are properly initialized. In practice > the > PTP_C

[Linuxptp-devel] [PATCH 2/2] phc_ctl: use PTP_CLOCK_GETCAPS2 ioctl if available

2022-11-15 Thread Jacob Keller
The PTP_CLOCK_GETCAPS2 ioctl is provided by kernel as a replacement for the original PTP_CLOCK_GETCAPS ioctl. This was done in order to provide ioctls which guarantee reserved fields are properly initialized. In practice the PTP_CLOCK_GETCAPS2 and PTP_CLOCK_GETCAPS both behave identically since PTP