Re: [Linuxptp-devel] [PATCH RFC 28/30] interface: Hide the implementation details.

2020-03-05 Thread Jacob Keller
On 3/4/2020 9:24 AM, Richard Cochran wrote: > On Tue, Feb 18, 2020 at 01:32:01PM -0800, Jacob Keller wrote: >> I'd appreciate if there was some way to ensure we catch the interface >> structure layout changing such that the definitions in clock.c and >> config.c aren't compatible with interface.c a

Re: [Linuxptp-devel] [PATCH RFC 28/30] interface: Hide the implementation details.

2020-03-04 Thread Richard Cochran
On Tue, Feb 18, 2020 at 01:32:01PM -0800, Jacob Keller wrote: > I'd appreciate if there was some way to ensure we catch the interface > structure layout changing such that the definitions in clock.c and > config.c aren't compatible with interface.c anymore. > > Perhaps there isn't a good solution

Re: [Linuxptp-devel] [PATCH RFC 28/30] interface: Hide the implementation details.

2020-02-18 Thread Jacob Keller
On 2/11/2020 6:04 AM, Richard Cochran wrote: > Now that a complete functional API is in place, there is no need to expose > the inner workings of the network interface data type. This patch converts > it into an opaque type while leaving the list marker visible to users > through a simple form of

[Linuxptp-devel] [PATCH RFC 28/30] interface: Hide the implementation details.

2020-02-11 Thread Richard Cochran
Now that a complete functional API is in place, there is no need to expose the inner workings of the network interface data type. This patch converts it into an opaque type while leaving the list marker visible to users through a simple form of "friendly exposition". Signed-off-by: Richard Cochra