Re: [Linuxptp-devel] [PATCH v1] servo: Implement offset statistics

2023-07-21 Thread Maciek Machnikowski
On 7/10/2023 12:33 PM, Maciek Machnikowski wrote: > > > On 7/10/2023 12:03 PM, Miroslav Lichvar wrote: >> On Mon, Jul 10, 2023 at 11:18:36AM +0200, Maciek Machnikowski wrote: >>> Do you mean the one in clock.c? If so, the clock_stats_display resets >>> them, so there's no way of printing the stat

Re: [Linuxptp-devel] [PATCH v1] servo: Implement offset statistics

2023-07-10 Thread Maciek Machnikowski
On 7/10/2023 12:03 PM, Miroslav Lichvar wrote: > On Mon, Jul 10, 2023 at 11:18:36AM +0200, Maciek Machnikowski wrote: >> Do you mean the one in clock.c? If so, the clock_stats_display resets >> them, so there's no way of printing the stats from a whole run - >> especially if we want to add some

Re: [Linuxptp-devel] [PATCH v1] servo: Implement offset statistics

2023-07-10 Thread Miroslav Lichvar
On Mon, Jul 10, 2023 at 11:18:36AM +0200, Maciek Machnikowski wrote: > Do you mean the one in clock.c? If so, the clock_stats_display resets > them, so there's no way of printing the stats from a whole run - > especially if we want to add some periodic read of these stats. The logged stats can be

Re: [Linuxptp-devel] [PATCH v1] servo: Implement offset statistics

2023-07-10 Thread Maciek Machnikowski
On 7/10/2023 10:33 AM, Miroslav Lichvar wrote: > On Mon, Jul 03, 2023 at 04:18:57PM +0200, Maciek Machnikowski wrote: >> Currently running servo reports current offsets in numerous tools, but lacks >> statistical data. Having the basic statistical data makes it easier to >> monitor >> running s

Re: [Linuxptp-devel] [PATCH v1] servo: Implement offset statistics

2023-07-10 Thread Miroslav Lichvar
On Mon, Jul 03, 2023 at 04:18:57PM +0200, Maciek Machnikowski wrote: > Currently running servo reports current offsets in numerous tools, but lacks > statistical data. Having the basic statistical data makes it easier to monitor > running servo (especially on long runs) and determine servo performa

Re: [Linuxptp-devel] [PATCH v1] servo: Implement offset statistics

2023-07-05 Thread Jacob Keller
On 7/3/2023 7:18 AM, Maciek Machnikowski wrote: > Currently running servo reports current offsets in numerous tools, but lacks > statistical data. Having the basic statistical data makes it easier to monitor > running servo (especially on long runs) and determine servo performance. > > This pat

[Linuxptp-devel] [PATCH v1] servo: Implement offset statistics

2023-07-03 Thread Maciek Machnikowski
Currently running servo reports current offsets in numerous tools, but lacks statistical data. Having the basic statistical data makes it easier to monitor running servo (especially on long runs) and determine servo performance. This patch reuses existing statistics implemented for tracking clock