Re: [Linuxptp-devel] [PATCH v1 0/6] Adding support for Automotive Profile

2018-09-24 Thread Patel, Vedang
Hi Richard, On Tue, 2018-09-18 at 06:06 -0700, Richard Cochran wrote: > On Thu, Sep 13, 2018 at 08:35:22PM -0700, Richard Cochran wrote: > > > > Yes, I'll get to it as soon as I can.  Overall I'm happy with this > > series, but I wanted to sit down and think through the automatic > > switch to MA

Re: [Linuxptp-devel] [PATCH v1 0/6] Adding support for Automotive Profile

2018-09-21 Thread Patel, Vedang
On Tue, 2018-09-18 at 18:07 -0700, Richard Cochran wrote: > On Tue, Sep 18, 2018 at 11:21:55PM +, Patel, Vedang wrote: > > > > Is there any particular reason you removed this? This is needed to > > process the FD_SYNC_RX_TIMER expiration when the master disconnects > > unexpectedly. > AFAICT t

Re: [Linuxptp-devel] [PATCH v1 0/6] Adding support for Automotive Profile

2018-09-18 Thread Richard Cochran
On Tue, Sep 18, 2018 at 11:21:55PM +, Patel, Vedang wrote: > Is there any particular reason you removed this? This is needed to > process the FD_SYNC_RX_TIMER expiration when the master disconnects > unexpectedly. AFAICT there is no point in handling that timer in any special way. After all, t

Re: [Linuxptp-devel] [PATCH v1 0/6] Adding support for Automotive Profile

2018-09-18 Thread Patel, Vedang
Thanks Richard for the response. I will work on this and send you a patch soon. Just one question below. On Tue, 2018-09-18 at 06:06 -0700, Richard Cochran wrote: > diff --git a/designated_fsm.c b/designated_fsm.c > index a56f962..9ccf4c9 100644 > --- a/designated_fsm.c > +++ b/designated_fsm.c >

Re: [Linuxptp-devel] [PATCH v1 0/6] Adding support for Automotive Profile

2018-09-18 Thread Richard Cochran
On Thu, Sep 13, 2018 at 08:35:22PM -0700, Richard Cochran wrote: > Yes, I'll get to it as soon as I can. Overall I'm happy with this > series, but I wanted to sit down and think through the automatic > switch to MASTER state that we discussed. Okay, I took your series and hacked the following dif

Re: [Linuxptp-devel] [PATCH v1 0/6] Adding support for Automotive Profile

2018-09-13 Thread Richard Cochran
On Thu, Sep 13, 2018 at 04:29:21PM +, Patel, Vedang wrote: > Is this series somewhere in your list of "things to review"? I just > wanted to check-in and make sure you didnt miss this. Yes, I'll get to it as soon as I can. Overall I'm happy with this series, but I wanted to sit down and think

Re: [Linuxptp-devel] [PATCH v1 0/6] Adding support for Automotive Profile

2018-09-13 Thread Patel, Vedang
Hi Richard, Is this series somewhere in your list of "things to review"? I just wanted to check-in and make sure you didnt miss this.  Thanks, Vedang On Thu, 2018-08-30 at 16:54 -0700, Vedang Patel wrote: > Changes in this version: > ~~~ > > Since the series has gone through

[Linuxptp-devel] [PATCH v1 0/6] Adding support for Automotive Profile

2018-08-30 Thread Vedang Patel
Changes in this version: ~~~ Since the series has gone through some feedback and is mature now, it is being posted as PATCH series instead of RFC. This version incorporates feedback from the last version of this series. The changes include: - Remove AVnu keyword from all comm