Re: [Linuxptp-devel] [PATCH v3 07/11] Subscription time limit

2014-05-05 Thread Richard Cochran
On Mon, May 05, 2014 at 02:54:04PM +0200, Jiri Benc wrote: > > I even thought about limiting the maximum value to a hour or so. The > client is supposed to renew the subscription, otherwise the time limit > would be useless. Fair enough. Thanks, Richard -

Re: [Linuxptp-devel] [PATCH v3 07/11] Subscription time limit

2014-05-05 Thread Jiri Benc
On Sat, 3 May 2014 20:32:01 +0200, Richard Cochran wrote: > 1. It is a good idea to let the client set the duration? You wanted to get rid of the magic constant in ptp4l, this allowed me to move it to phc2sys ;-) Okay, seriously: I don't think this is a problem. It is limited to UDS and the worst

Re: [Linuxptp-devel] [PATCH v3 07/11] Subscription time limit

2014-05-03 Thread Richard Cochran
On Fri, May 02, 2014 at 12:37:50PM +0200, Jiri Benc wrote: > Add expiration time to subscriptions; they need to be renewed before they > expiry. This way, the subscription automatically times out when phc2sys is > killed. > > Signed-off-by: Jiri Benc > --- > clock.c | 27 ++

[Linuxptp-devel] [PATCH v3 07/11] Subscription time limit

2014-05-02 Thread Jiri Benc
Add expiration time to subscriptions; they need to be renewed before they expiry. This way, the subscription automatically times out when phc2sys is killed. Signed-off-by: Jiri Benc --- clock.c | 27 +-- tlv.c |8 tlv.h |1 + 3 files changed, 34 ins